search

DataDog / datadogpy

The Datadog Python library
https://datadoghq.com/
Other
609 stars 303 forks source link

Add SLO search endpoint and update get_all #742

Closed Throckmortra closed 1 year ago

Throckmortra commented 1 year ago

What does this PR do?

https://github.com/DataDog/datadogpy/issues/741

Adds missing search endpoint now supported in SLOs and updates get_all for new query params https://docs.datadoghq.com/api/latest/service-level-objectives/#search-for-slos https://docs.datadoghq.com/api/latest/service-level-objectives/#get-all-slos

Description of the Change

same as above

Verification Process

Tested locally :D And added some more pertinent lines to the slo integration test

Throckmortra commented 1 year ago

/azp run DataDog.datadogpy.integration

azure-pipelines[bot] commented 1 year ago
Commenter does not have sufficient privileges for PR 742 in repo DataDog/datadogpy
therve commented 1 year ago

Hi,

Would be interested in using https://github.com/DataDog/datadog-api-client-python instead? Anything particular that you need in datadogpy? Thanks.

Throckmortra commented 1 year ago

@therve in the future yes but for now I'm required to use this. Just having a little trouble getting the tests working but I promise this change works

Throckmortra commented 1 year ago

vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/home/vsts/work/1/s/tests/integration/api/cassettes/TestDatadog.test_service_level_objective_crud.yaml') in your current record mode ('none').

Could someone please explain how I get the test environment to record cassettes for new api resources?

EDIT: therve said he would record the cassettes early next week

therve commented 1 year ago

Merged as #744, thanks!