DataDog / datadogpy

The Datadog Python library
https://datadoghq.com/
Other
612 stars 302 forks source link

Fix typos that break dogshell #755

Closed louy closed 1 year ago

louy commented 1 year ago

What does this PR do?

Fix a few typos that break dogshell cli

➜  Projects dog --help
Traceback (most recent call last):
  File "/Users/louay/.asdf/installs/python/3.11.1/bin/dog", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/__init__.py", line 96, in main
    DashboardListClient.setup_parser(subparsers)
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/dashboard_list.py", line 128, in setup_parser
    delete_dashboards_v2_parser = verb_parsers.add_parser(
                                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/argparse.py", line 1185, in add_parser
    raise ArgumentError(self, _('conflicting subparser: %s') % name)
argparse.ArgumentError: argument verb: conflicting subparser: delete_dashboards
➜  Projects dog --help
Traceback (most recent call last):
  File "/Users/louay/.asdf/installs/python/3.11.1/bin/dog", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/__init__.py", line 100, in main
    ServiceLevelObjectiveClient.setup_parser(subparsers)
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/service_level_objective.py", line 150, in setup_parser
    delete_timeframe_parser = verb_parsers.add_parser("delete_many", help="Delete a SLO timeframe")
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/argparse.py", line 1185, in add_parser
    raise ArgumentError(self, _('conflicting subparser: %s') % name)
argparse.ArgumentError: argument verb: conflicting subparser: delete_many

Description of the Change

Typos in arguments passed to argparse

Alternate Designs

Possible Drawbacks

Verification Process

Tested locally, no more errors being thrown

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

louy commented 1 year ago

Not stale

nkzou commented 1 year ago

Fixed by #760