DataDog / datadogpy

The Datadog Python library
https://datadoghq.com/
Other
609 stars 303 forks source link

Make it possible to post related events #786

Open gchpaco opened 1 year ago

gchpaco commented 1 year ago

The current version of dogshell interprets --related_event_id as a string, not an integer, which means the backend refuses to work with it. The fix is simple; to tell argparse that it's an int.

Requirements for Contributing to this repository

What does this PR do?

Fix #785 by adding typing to related event IDs in argparse.

Description of the Change

To ensure that the JSON API is sent an integer and not a string, we add type=int to the relevant argparse declaration.

Alternate Designs

You could do it at the call site, or otherwise parse it, but argparse makes this relatively easy.

Possible Drawbacks

If you were in the habit of posting random garbage to related event ID and expecting it to fail, it will now fail slightly earlier.

Review checklist (to be filled by reviewers)

github-actions[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.