This patch makes the client_transport tag dynamic and updates it every time the socket_path property is updated.
Description of the Change
datadog.initialize reassigns socket_path property on the global statsd instance, but the client_transport tag was computed in the constructor and never updated, causing client to misreport transport as udp when a unix socket was actually used.
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.
What does this PR do?
This patch makes the
client_transporttag dynamic and updates it every time thesocket_pathproperty is updated.Description of the Change
datadog.initializereassignssocket_pathproperty on the global statsd instance, but theclient_transporttag was computed in the constructor and never updated, causing client to misreport transport as udp when a unix socket was actually used.Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.