Closed vickenty closed 3 months ago
Fix potential metric loss when open_buffer is combined with disable_buffering=False.
Remove call to _reset_buffer from open_buffer.
_reset_buffer
open_buffer
When disable_buffering=False, the buffer may contain still unsent metrics, which are lost when we reset the buffer.
changelog/
backward-incompatible
do-not-merge/
kind/
severity/
What does this PR do?
Fix potential metric loss when open_buffer is combined with disable_buffering=False.
Description of the Change
Remove call to
_reset_buffer
fromopen_buffer
.When disable_buffering=False, the buffer may contain still unsent metrics, which are lost when we reset the buffer.
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.