Update libddwaf to 1.13.1 (actually 1.14.0)

iunanua commented 1 year ago

What does this PR do?

Update libddwaf to 1.13.1:

replacing ddwaf_object_signed calls with ddwaf_object_string_from_signed #interface-changes

Update libddwaf to 1.11.0:

replacing ddwaf_ruleset_info with ddwaf_object and removing unused ruleset_info related methods #ruleset-parsing-diagnostics
updating DDWAF::init and DDWAF:update returned object due changes in ddwaf_result #ruleset-parsing-diagnostics
replacing rulesInfo property with diagnostics property #ruleset-parsing-diagnostics
renaming data property as events #events--actions-as-ddwaf_object
changing the type of events and actions properties to object #events--actions-as-ddwaf_object

Motivation

Additional Notes

Describe how to test your changes

Checklist

[ ] The CHANGELOG.md has been updated
[ ] Unit tests have been updated and pass
[ ] If known, an appropriate milestone has been selected

simon-id commented 1 year ago

This will be done in an ulterior PR

~In the new versions, libddwaf released builds for arm7 and linux x86, which we didn't support until now. APM was not too happy about that because dd-trace is supposed to support them. So it would be nice if we could include those now. You can try by removing this line: https://github.com/DataDog/dd-native-appsec-js/blob/main/.github/workflows/build.yml#L33~

simon-id commented 1 year ago

You're missing ddwaf_result.derivatives: https://github.com/DataDog/libddwaf/blob/1.13.1/include/ddwaf.h#L168C18-L168C29

iunanua commented 1 year ago

You're missing ddwaf_result.derivatives: https://github.com/DataDog/libddwaf/blob/1.13.1/include/ddwaf.h#L168C18-L168C29

As we are not using preprocessors I decided to keep it simple and not include the derivatives field...

DataDog / dd-native-appsec-js