Don't log at `warn` level when minified is disabled. - Githubissues

DataDog / dd-sdk-android-gradle-plugin

The Datadog Gradle Plugin for Android

Apache License 2.0

14 stars 9 forks source link

Don't log at `warn` level when minified is disabled. #185

Closed yogurtearl closed 10 months ago

yogurtearl commented 1 year ago

Turn this to a LOGGER.info instead of warn https://github.com/DataDog/dd-sdk-android-gradle-plugin/blob/47979b8502ebd63cf71b29bc607a79794b6a1d38/dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt#L79-L82

Describe what happened This plugin prints this for all non-minified variants.

Minifying disabled for variant debug, no upload task created

This pollutes the warn logs with unnecessary detail.

Steps to reproduce the issue:

Turn off minification for the debug build.

Describe what you expected:

This should be an info log. Or maybe only warn if the buildType is release and minified is not enabled?

Additional context

Gradle version: 8.3
OS version: macOS 13.4
Plugin version: 1.9.0

xgouchet commented 1 year ago

Hi @yogurtearl , thanks a lot for opening this feature request, we'll try and improve our logging soon.