Closed fuzzybinary closed 6 months ago
Merging #220 (851894e) into develop (5895876) will increase coverage by
2.94%
. The diff coverage is77.73%
.:exclamation: Current head 851894e differs from pull request most recent head 739345e. Consider uploading reports for the commit 739345e to get more accurate results
Resolved most of the comments -- I still need to do the functional tests so I'll jump on that next.
@0xnm Fixed and amended the previous commit
What does this PR do?
This adds tasks for each variant,
uploadNdkSymbolFiles{Variant}
to upload symbols from native artifacts to Datadog. It utilizes similar logic fromDdMappingFileUpload
but encapsulates it intoDdFileUploadTask
. This logic is duplicated for now but we should probably refactorDdMappingFileUpload
to use theDdFileUploadTask
base class at some point.NDK Symbol files have the key
ndk_symbol_file
, typendk_symbol_file
, and retain their original file name when uploading. The architecture of the symbol file is encoded into the "additional info" map when uploading.Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)