search

DataDog / dd-sdk-android-gradle-plugin

The Datadog Gradle Plugin for Android
Apache License 2.0
14 stars 9 forks source link

chore: Refactor DdMapingFileUploadTask #222

Closed fuzzybinary closed 6 months ago

fuzzybinary commented 6 months ago

What does this PR do?

Remove duplication and have DdMappingFileUploadTask inherit from FileUploadTask

Review checklist (to be filled by reviewers)

codecov-commenter commented 6 months ago

Codecov Report

Merging #222 (71dc7a2) into develop (105e129) will increase coverage by 3.23%. Report is 16 commits behind head on develop. The diff coverage is 80.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #222 +/- ## ============================================= + Coverage 78.20% 81.43% +3.23% - Complexity 187 204 +17 ============================================= Files 22 26 +4 Lines 665 797 +132 Branches 85 104 +19 ============================================= + Hits 520 649 +129 + Misses 116 111 -5 - Partials 29 37 +8 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...m/datadog/gradle/plugin/DdMappingFileUploadTask.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZE1hcHBpbmdGaWxlVXBsb2FkVGFzay5rdA==) | `91.67% <100.00%> (+2.63%)` | :arrow_up: | | [...og/gradle/plugin/internal/GitRepositoryDetector.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9pbnRlcm5hbC9HaXRSZXBvc2l0b3J5RGV0ZWN0b3Iua3Q=) | `97.14% <100.00%> (+0.08%)` | :arrow_up: | | [...lin/com/datadog/gradle/plugin/internal/Uploader.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9pbnRlcm5hbC9VcGxvYWRlci5rdA==) | `100.00% <100.00%> (ø)` | | | [...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZEFuZHJvaWRHcmFkbGVQbHVnaW4ua3Q=) | `68.67% <90.91%> (+13.70%)` | :arrow_up: | | [...m/datadog/gradle/plugin/internal/OkHttpUploader.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9pbnRlcm5hbC9Pa0h0dHBVcGxvYWRlci5rdA==) | `82.93% <77.78%> (-1.37%)` | :arrow_down: | | [...in/kotlin/com/datadog/gradle/plugin/DdTaskUtils.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZFRhc2tVdGlscy5rdA==) | `57.14% <57.14%> (ø)` | | | [...datadog/gradle/plugin/DdNdkSymbolFileUploadTask.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZE5ka1N5bWJvbEZpbGVVcGxvYWRUYXNrLmt0) | `75.00% <75.00%> (ø)` | | | [...tlin/com/datadog/gradle/plugin/DdFileUploadTask.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZEZpbGVVcGxvYWRUYXNrLmt0) | `82.11% <82.11%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/222/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)