DataDog / dd-sdk-android-gradle-plugin

The Datadog Gradle Plugin for Android
Apache License 2.0
14 stars 9 forks source link

fix: Standardize architectures #249

Closed fuzzybinary closed 5 months ago

fuzzybinary commented 5 months ago

What does this PR do?

The symbolication service currently understands arm, arm64, x86 and x64 as valid symbol file architectures. Instead of adding the Android ABIs, we map them to those architectures instead.

Review checklist (to be filled by reviewers)

codecov-commenter commented 5 months ago

Codecov Report

Merging #249 (bb01f6f) into develop (81aace0) will increase coverage by 0.43%. The diff coverage is 90.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #249 +/- ## ============================================= + Coverage 81.30% 81.73% +0.43% - Complexity 203 205 +2 ============================================= Files 26 26 Lines 802 810 +8 Branches 104 104 ============================================= + Hits 652 662 +10 Misses 112 112 + Partials 38 36 -2 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/249?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...datadog/gradle/plugin/DdNdkSymbolFileUploadTask.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/249?src=pr&el=tree&filepath=dd-sdk-android-gradle-plugin%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fgradle%2Fplugin%2FDdNdkSymbolFileUploadTask.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZE5ka1N5bWJvbEZpbGVVcGxvYWRUYXNrLmt0) | `77.63% <90.91%> (+2.63%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/249/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)