DataDog / dd-sdk-android-gradle-plugin

The Datadog Gradle Plugin for Android
Apache License 2.0
14 stars 9 forks source link

RUM-4292: Mark upload task as not compatible with configuration cache #256

Closed 0xnm closed 5 months ago

0xnm commented 5 months ago

What does this PR do?

This PR will mark upload task as not compatible with configuration cache, meaning it won't be recorded for the configuration cache.

This fixes the issue #251.

Note, that we may come back to the configuration cache support for this task in the future, but for now the issue is that task input expects build ID file to be present, and it will be present only after build run, not at the configuration phase. Complete configuration cache support thus will require major logic changes, which may be not worth it, considering that configuration for this task is very fast.

Review checklist (to be filled by reviewers)

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.75%. Comparing base (c3626c4) to head (c7360f4). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #256 +/- ## ============================================= - Coverage 80.78% 80.75% -0.03% - Complexity 205 206 +1 ============================================= Files 26 26 Lines 822 826 +4 Branches 105 108 +3 ============================================= + Hits 664 667 +3 + Misses 121 114 -7 - Partials 37 45 +8 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/256?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/256?src=pr&el=tree&filepath=dd-sdk-android-gradle-plugin%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fgradle%2Fplugin%2FDdAndroidGradlePlugin.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZEFuZHJvaWRHcmFkbGVQbHVnaW4ua3Q=) | `68.82% <66.67%> (-0.04%)` | :arrow_down: | | [...in/kotlin/com/datadog/gradle/plugin/DdTaskUtils.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/256?src=pr&el=tree&filepath=dd-sdk-android-gradle-plugin%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fgradle%2Fplugin%2FDdTaskUtils.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZFRhc2tVdGlscy5rdA==) | `68.18% <37.50%> (+6.28%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/256/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)