DataDog / dd-sdk-android-gradle-plugin

The Datadog Gradle Plugin for Android
Apache License 2.0
14 stars 9 forks source link

RUM-4406: Avoid BuildId task creation if there is no obfuscation or native build providers registered #259

Closed 0xnm closed 6 months ago

0xnm commented 6 months ago

What does this PR do?

This PR will make build ID generation task to be created only if there is obfuscation enabled or there are native build providers.

Partially addresses #258.

Review checklist (to be filled by reviewers)

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.41%. Comparing base (db3ff0d) to head (ecf9853).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #259 +/- ## ============================================= - Coverage 80.87% 80.41% -0.46% - Complexity 207 208 +1 ============================================= Files 26 26 Lines 826 827 +1 Branches 108 110 +2 ============================================= - Hits 668 665 -3 - Misses 114 116 +2 - Partials 44 46 +2 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/259?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...datadog/gradle/plugin/DdNdkSymbolFileUploadTask.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/259?src=pr&el=tree&filepath=dd-sdk-android-gradle-plugin%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fgradle%2Fplugin%2FDdNdkSymbolFileUploadTask.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZE5ka1N5bWJvbEZpbGVVcGxvYWRUYXNrLmt0) | `76.39% <100.00%> (-1.24%)` | :arrow_down: | | [...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/259?src=pr&el=tree&filepath=dd-sdk-android-gradle-plugin%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fgradle%2Fplugin%2FDdAndroidGradlePlugin.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtZ3JhZGxlLXBsdWdpbi9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvZ3JhZGxlL3BsdWdpbi9EZEFuZHJvaWRHcmFkbGVQbHVnaW4ua3Q=) | `67.61% <50.00%> (-1.21%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android-gradle-plugin/pull/259/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)