Update Detekt API version used to 1.23.0

0xnm commented 4 months ago

What does this PR do?

I noticed some Kotlin 1.7 artifacts downloaded for the test classpath and they were coming from Detekt 1.22.0.

This PR updates Detekt to 1.23.0 to be better aligned with the version we use for the checks (1.23.4) and to stop Kotlin 1.7 artifacts being downloaded.

Detekt 1.23.4 is not used because it will bring Kotlin 1.9, this is not what we want.

Detekt changelog is here.

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

codecov-commenter commented 4 months ago

Codecov Report

Merging #1988 (b658564) into develop (ebf7542) will decrease coverage by 0.07%. Report is 19 commits behind head on develop. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1988 +/- ## =========================================== - Coverage 83.68% 83.61% -0.07% =========================================== Files 487 487 Lines 17736 17741 +5 Branches 2663 2663 =========================================== - Hits 14842 14834 -8 - Misses 2167 2180 +13 Partials 727 727 ``` [see 27 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/1988/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)

xgouchet commented 4 months ago

[!NOTE] We also need to update the shared pipeline to 1.23.0 in dd-source

0xnm commented 4 months ago

@xgouchet It is 1.23.4 there in the latest version. Or you mean something else?

Anyway, with this PR tests are passing on macOS, but failing in the CI (Linux) container, so I probably keep this PR on hold for now.

DataDog / dd-sdk-android