DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
146 stars 59 forks source link

Remove some unused IAST/CI Visibility classes #2000

Closed 0xnm closed 4 months ago

0xnm commented 4 months ago

What does this PR do?

This PR removes some unused IAST/CI Visibility classes.

Review checklist (to be filled by reviewers)

mariusc83 commented 4 months ago

Thanks a lot for the help. Can you please rebase it on top of my current branch: mconstantin/rum-3389/add-trace-otel-feature-integration-tests, this way you can have the integration tests in place to verify.

codecov-commenter commented 4 months ago

Codecov Report

Merging #2000 (4dc4063) into feature/otel-support (3bd8514) will increase coverage by 2.84%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/otel-support #2000 +/- ## ======================================================== + Coverage 60.35% 63.19% +2.84% ======================================================== Files 808 753 -55 Lines 30223 28501 -1722 Branches 4951 4677 -274 ======================================================== - Hits 18241 18010 -231 + Misses 10761 9303 -1458 + Partials 1221 1188 -33 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2000?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...ce/src/main/java/com/datadog/trace/api/Config.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2000?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fapi%2FConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9hcGkvQ29uZmlnLmphdmE=) | `49.09% <ø> (-2.45%)` | :arrow_down: | | [...java/com/datadog/trace/api/InstrumenterConfig.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2000?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fapi%2FInstrumenterConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9hcGkvSW5zdHJ1bWVudGVyQ29uZmlnLmphdmE=) | `53.33% <ø> (-0.45%)` | :arrow_down: | | [...c/main/java/com/datadog/trace/core/CoreTracer.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2000?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2FCoreTracer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL0NvcmVUcmFjZXIuamF2YQ==) | `64.53% <ø> (+0.64%)` | :arrow_up: | | [...main/java/com/datadog/trace/core/StatusLogger.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2000?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2FStatusLogger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL1N0YXR1c0xvZ2dlci5qYXZh) | `2.44% <ø> (+0.23%)` | :arrow_up: | ... and [37 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2000/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)