DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
146 stars 59 forks source link

RUM-4134 Remove moshi dependency from trace module #2003

Closed mariusc83 closed 4 months ago

mariusc83 commented 4 months ago

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

codecov-commenter commented 4 months ago

Codecov Report

Merging #2003 (478ba84) into feature/otel-support (9a7e978) will increase coverage by 0.71%. The diff coverage is 78.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/otel-support #2003 +/- ## ======================================================== + Coverage 63.17% 63.88% +0.71% ======================================================== Files 754 752 -2 Lines 28504 28368 -136 Branches 4679 4680 +1 ======================================================== + Hits 18006 18121 +115 + Misses 9300 9043 -257 - Partials 1198 1204 +6 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...c/main/java/com/datadog/trace/core/CoreTracer.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2FCoreTracer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL0NvcmVUcmFjZXIuamF2YQ==) | `64.46% <ø> (-0.07%)` | :arrow_down: | | [...ain/java/com/datadog/trace/core/util/MapUtils.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2Futil%2FMapUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL3V0aWwvTWFwVXRpbHMuamF2YQ==) | `83.33% <83.33%> (ø)` | | | [...a/com/datadog/trace/core/util/JsonObjectUtils.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2Futil%2FJsonObjectUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL3V0aWwvSnNvbk9iamVjdFV0aWxzLmphdmE=) | `87.50% <87.50%> (ø)` | | | [...adog/trace/common/sampling/TraceSamplingRules.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcommon%2Fsampling%2FTraceSamplingRules.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb21tb24vc2FtcGxpbmcvVHJhY2VTYW1wbGluZ1J1bGVzLmphdmE=) | `89.89% <89.77%> (+71.55%)` | :arrow_up: | | [...tadog/trace/common/sampling/SpanSamplingRules.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcommon%2Fsampling%2FSpanSamplingRules.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb21tb24vc2FtcGxpbmcvU3BhblNhbXBsaW5nUnVsZXMuamF2YQ==) | `90.35% <90.35%> (+78.45%)` | :arrow_up: | | [...c/main/java/com/datadog/trace/core/DDSpanLink.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2FDDSpanLink.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL0REU3BhbkxpbmsuamF2YQ==) | `5.56% <5.56%> (+1.11%)` | :arrow_up: | ... and [35 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2003/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)