Make constructors of `DatadogSite` private

0xnm commented 4 months ago

What does this PR do?

Constructors of DatadogSite shouldn't be public.

This may be see as a breaking change (removing items from public API), but this was never intended to be public.

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.77%. Comparing base (cff8b54) to head (9354705).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #2010 +/- ## =========================================== + Coverage 83.71% 83.77% +0.06% =========================================== Files 488 488 Lines 17736 17767 +31 Branches 2659 2666 +7 =========================================== + Hits 14846 14883 +37 + Misses 2177 2169 -8 - Partials 713 715 +2 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2010?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...src/main/kotlin/com/datadog/android/DatadogSite.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2010?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2FDatadogSite.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9EYXRhZG9nU2l0ZS5rdA==) | `100.00% <100.00%> (ø)` | | ... and [30 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2010/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)

0xnm commented 4 months ago

@xgouchet yes, my concern was mostly the look of the API surface file, these custom constructors are declared there.

DataDog / dd-sdk-android