Closed xgouchet closed 4 months ago
Attention: Patch coverage is 87.91209%
with 33 lines
in your changes are missing coverage. Please review.
Project coverage is 83.42%. Comparing base (
0c3e683
) to head (3c7446f
). Report is 2 commits behind head on develop.
What does this PR do?
This PR improves the overall way we deal with privacy settings in the SR modules.
Motivation
The way we used to do thing made things difficult as it implied:
Map<Privacy, Map<Class<View>, Mapper<*>>>
which was difficult to follow and implement)Additional Notes
This PR uses the existing
MappingContext
that is passed to mappers during the snapshot creation to pass in the current privacy setting. This means each mapper deals with the privacy at snapshot time, and have all the logic in one place, instead of split in two or three classes. Also it means that the privacy could be changed dynamically without effort (e.g. with remote config).