DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
141 stars 57 forks source link

RUM-4369: Support additional properties in Telemetry Error events #2025

Closed 0xnm closed 2 months ago

0xnm commented 2 months ago

What does this PR do?

This PR adds support for the additionalProperties for the TelemetryErrorEvent. They are already supported in TelemetryDebugEvent, but were missing for the errors.

Code is updated to propagate these additional properties to the telemetry.

Review checklist (to be filled by reviewers)

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 83.21%. Comparing base (3d0a4d2) to head (9b200e9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2025 +/- ## =========================================== - Coverage 83.31% 83.21% -0.10% =========================================== Files 485 486 +1 Lines 17671 17680 +9 Branches 2685 2687 +2 =========================================== - Hits 14722 14712 -10 - Misses 2213 2232 +19 Partials 736 736 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...lin/com/datadog/android/rum/internal/RumFeature.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2FRumFeature.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9SdW1GZWF0dXJlLmt0) | `93.90% <100.00%> (+1.24%)` | :arrow_up: | | [.../android/rum/internal/monitor/DatadogRumMonitor.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmonitor%2FDatadogRumMonitor.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tb25pdG9yL0RhdGFkb2dSdW1Nb25pdG9yLmt0) | `86.71% <100.00%> (+0.95%)` | :arrow_up: | | [...tlin/com/datadog/android/core/SdkInternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2FSdkInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL1Nka0ludGVybmFsTG9nZ2VyLmt0) | `90.11% <87.50%> (-2.11%)` | :arrow_down: | | [...android/rum/internal/monitor/AdvancedRumMonitor.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmonitor%2FAdvancedRumMonitor.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tb25pdG9yL0FkdmFuY2VkUnVtTW9uaXRvci5rdA==) | `66.67% <66.67%> (ø)` | | | [...ndroid/telemetry/internal/TelemetryEventHandler.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftelemetry%2Finternal%2FTelemetryEventHandler.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3RlbGVtZXRyeS9pbnRlcm5hbC9UZWxlbWV0cnlFdmVudEhhbmRsZXIua3Q=) | `79.59% <50.00%> (+1.47%)` | :arrow_up: | | [...om/datadog/android/telemetry/internal/Telemetry.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftelemetry%2Finternal%2FTelemetry.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3RlbGVtZXRyeS9pbnRlcm5hbC9UZWxlbWV0cnkua3Q=) | `11.11% <0.00%> (-1.39%)` | :arrow_down: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2025/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)