search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
141 stars 57 forks source link

Improve SeekBarMapper #2037

Closed xgouchet closed 2 months ago

xgouchet commented 2 months ago

What does this PR do?

Improve SeekBarMapper and its unit tests:

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 79.34783% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 83.17%. Comparing base (a814f9f) to head (a23e0e0). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2037 +/- ## =========================================== + Coverage 82.93% 83.17% +0.24% =========================================== Files 491 491 Lines 17700 17697 -3 Branches 2683 2686 +3 =========================================== + Hits 14678 14718 +40 + Misses 2285 2238 -47 - Partials 737 741 +4 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...nreplay/material/internal/SliderWireframeMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay-material%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Fmaterial%2Finternal%2FSliderWireframeMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXktbWF0ZXJpYWwvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9tYXRlcmlhbC9pbnRlcm5hbC9TbGlkZXJXaXJlZnJhbWVNYXBwZXIua3Q=) | `97.40% <ø> (ø)` | | | [.../sessionreplay/internal/DefaultRecorderProvider.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2FDefaultRecorderProvider.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9EZWZhdWx0UmVjb3JkZXJQcm92aWRlci5rdA==) | `92.31% <100.00%> (+6.59%)` | :arrow_up: | | [...eplay/internal/recorder/mapper/BasePickerMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2Fmapper%2FBasePickerMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9tYXBwZXIvQmFzZVBpY2tlck1hcHBlci5rdA==) | `100.00% <ø> (ø)` | | | [...nternal/recorder/mapper/CheckableTextViewMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2Fmapper%2FCheckableTextViewMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9tYXBwZXIvQ2hlY2thYmxlVGV4dFZpZXdNYXBwZXIua3Q=) | `96.55% <ø> (+39.66%)` | :arrow_up: | | [.../internal/recorder/mapper/CheckedTextViewMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2Fmapper%2FCheckedTextViewMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9tYXBwZXIvQ2hlY2tlZFRleHRWaWV3TWFwcGVyLmt0) | `95.65% <ø> (ø)` | | | [...lay/internal/recorder/mapper/NumberPickerMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2Fmapper%2FNumberPickerMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9tYXBwZXIvTnVtYmVyUGlja2VyTWFwcGVyLmt0) | `99.19% <ø> (ø)` | | | [...lay/internal/recorder/mapper/SwitchCompatMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2Fmapper%2FSwitchCompatMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9tYXBwZXIvU3dpdGNoQ29tcGF0TWFwcGVyLmt0) | `88.37% <ø> (+17.05%)` | :arrow_up: | | [.../android/sessionreplay/internal/utils/MiscUtils.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Futils%2FMiscUtils.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC91dGlscy9NaXNjVXRpbHMua3Q=) | `72.73% <ø> (+1.82%)` | :arrow_up: | | [...ssionreplay/recorder/mapper/BaseWireframeMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Frecorder%2Fmapper%2FBaseWireframeMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9yZWNvcmRlci9tYXBwZXIvQmFzZVdpcmVmcmFtZU1hcHBlci5rdA==) | `100.00% <ø> (ø)` | | | [...id/sessionreplay/recorder/mapper/TextViewMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Frecorder%2Fmapper%2FTextViewMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9yZWNvcmRlci9tYXBwZXIvVGV4dFZpZXdNYXBwZXIua3Q=) | `90.91% <ø> (+1.33%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | | ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2037/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)