search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
150 stars 59 forks source link

Update the Method Call metric usage #2040

Closed xgouchet closed 4 months ago

xgouchet commented 4 months ago

What does this PR do?

Update the MethodCall metric code to allow multiple usage with different operation names + cleanup some SR code

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.69231% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 83.03%. Comparing base (9117094) to head (f4f8507).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2040 +/- ## =========================================== - Coverage 83.23% 83.03% -0.20% =========================================== Files 491 493 +2 Lines 17685 17701 +16 Branches 2685 2685 =========================================== - Hits 14719 14697 -22 - Misses 2227 2271 +44 + Partials 739 733 -6 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...n/kotlin/com/datadog/android/api/InternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fapi%2FInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9hcGkvSW50ZXJuYWxMb2dnZXIua3Q=) | `100.00% <ø> (ø)` | | | [...in/com/datadog/android/api/feature/FeatureScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fapi%2Ffeature%2FFeatureScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9hcGkvZmVhdHVyZS9GZWF0dXJlU2NvcGUua3Q=) | `0.00% <ø> (ø)` | | | [...in/com/datadog/android/core/internal/SdkFeature.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2FSdkFeature.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL1Nka0ZlYXR1cmUua3Q=) | `89.10% <ø> (+2.77%)` | :arrow_up: | | [.../android/core/internal/logger/SdkInternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Flogger%2FSdkInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL2xvZ2dlci9TZGtJbnRlcm5hbExvZ2dlci5rdA==) | `85.71% <100.00%> (-2.20%)` | :arrow_down: | | [...oid/core/internal/metrics/MethodCalledTelemetry.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Fmetrics%2FMethodCalledTelemetry.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL21ldHJpY3MvTWV0aG9kQ2FsbGVkVGVsZW1ldHJ5Lmt0) | `100.00% <100.00%> (ø)` | | | [.../datadog/android/core/metrics/PerformanceMetric.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Fmetrics%2FPerformanceMetric.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL21ldHJpY3MvUGVyZm9ybWFuY2VNZXRyaWMua3Q=) | `0.00% <ø> (ø)` | | | [.../sessionreplay/internal/DefaultRecorderProvider.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2FDefaultRecorderProvider.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9EZWZhdWx0UmVjb3JkZXJQcm92aWRlci5rdA==) | `92.31% <100.00%> (ø)` | | | [...nreplay/internal/recorder/SessionReplayRecorder.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2FSessionReplayRecorder.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9TZXNzaW9uUmVwbGF5UmVjb3JkZXIua3Q=) | `96.52% <100.00%> (+0.09%)` | :arrow_up: | | [...essionreplay/internal/recorder/SnapshotProducer.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2FSnapshotProducer.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9TbmFwc2hvdFByb2R1Y2VyLmt0) | `90.91% <100.00%> (+3.03%)` | :arrow_up: | | [...nreplay/internal/recorder/ViewOnDrawInterceptor.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2FViewOnDrawInterceptor.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9WaWV3T25EcmF3SW50ZXJjZXB0b3Iua3Q=) | `88.89% <100.00%> (-1.59%)` | :arrow_down: | | ... and [4 more](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2040/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)