search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
150 stars 59 forks source link

Fix some detekt issues #2043

Closed mariusc83 closed 4 months ago

mariusc83 commented 4 months ago

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.19%. Comparing base (9117094) to head (4f942d6). Report is 55 commits behind head on nogorodnikov/merge-develop-into-otel-support-170424.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## nogorodnikov/merge-develop-into-otel-support-170424 #2043 +/- ## ======================================================================================== - Coverage 83.23% 64.19% -19.03% ======================================================================================== Files 491 759 +268 Lines 17685 28314 +10629 Branches 2685 4757 +2072 ======================================================================================== + Hits 14719 18176 +3457 - Misses 2227 8912 +6685 - Partials 739 1226 +487 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...ce/opentelemetry/internal/DatadogContextStorage.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace-otel%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftrace%2Fopentelemetry%2Finternal%2FDatadogContextStorage.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Utb3RlbC9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC90cmFjZS9vcGVudGVsZW1ldHJ5L2ludGVybmFsL0RhdGFkb2dDb250ZXh0U3RvcmFnZS5rdA==) | `66.67% <ø> (ø)` | | | [...ndroid/trace/opentelemetry/internal/OtelContext.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace-otel%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftrace%2Fopentelemetry%2Finternal%2FOtelContext.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Utb3RlbC9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC90cmFjZS9vcGVudGVsZW1ldHJ5L2ludGVybmFsL090ZWxDb250ZXh0Lmt0) | `89.47% <ø> (ø)` | | | [.../android/trace/opentelemetry/internal/OtelScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace-otel%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftrace%2Fopentelemetry%2Finternal%2FOtelScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Utb3RlbC9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC90cmFjZS9vcGVudGVsZW1ldHJ5L2ludGVybmFsL090ZWxTY29wZS5rdA==) | `100.00% <ø> (ø)` | | | [.../kotlin/com/datadog/android/trace/AndroidTracer.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftrace%2FAndroidTracer.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvdHJhY2UvQW5kcm9pZFRyYWNlci5rdA==) | `96.00% <ø> (-0.23%)` | :arrow_down: | | [...atadog/android/trace/internal/FeatureSdkCoreExt.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftrace%2Finternal%2FFeatureSdkCoreExt.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvdHJhY2UvaW50ZXJuYWwvRmVhdHVyZVNka0NvcmVFeHQua3Q=) | `100.00% <ø> (ø)` | | | [...dog/android/trace/internal/data/OtelTraceWriter.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftrace%2Finternal%2Fdata%2FOtelTraceWriter.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvdHJhY2UvaW50ZXJuYWwvZGF0YS9PdGVsVHJhY2VXcml0ZXIua3Q=) | `88.46% <ø> (ø)` | | ... and [131 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2043/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)