Closed mariusc83 closed 1 month ago
Attention: Patch coverage is 34.22460%
with 369 lines
in your changes are missing coverage. Please review.
Project coverage is 66.82%. Comparing base (
ad06c50
) to head (da0a254
). Report is 1 commits behind head on feature/otel-support.
What does this PR do?
In this PR we are cleaning up the imported Java code for the
CoreTracer
and make it Java 7 compatible in order to not require desugaring on Android 23 and below.The are several steps in achieving this:
CoreTracer
as I realized that we will be needing this later for Context propagationjava.util.Base64
,java.util.Map
,java.util.Stream
is being used in order to make it Java 7 compatibleHave in mind that maybe some more cleaning could be performed but I don't find this idea wise. What I could clean so far was code that I was really certain that it cannot affect the current functionality, it will not have any impact on the APM metrics and will not have repercussions later. We already went into trouble by removing the
Injector
which seemed not to be used for the moment and I just realized during this PR work that this will have a negative impact later.Motivation
What inspired you to submit this pull request?
Additional Notes
I performed a Profiling by analyzing the CPU consumption and Memory consumption while using the new Otel code and I could not see any potential issue (spike).
Review checklist (to be filled by reviewers)