search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
141 stars 57 forks source link

RUM-4719 Improve ButtonMapper #2070

Closed xgouchet closed 1 month ago

xgouchet commented 1 month ago

What does this PR do?

Improve the ButtonMapper by letting it extend TextViewMapper, and add more exhaustive and cleaner tests

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.84%. Comparing base (8e9ada1) to head (fbfa373). Report is 12 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2070 +/- ## =========================================== - Coverage 83.22% 82.84% -0.38% =========================================== Files 494 494 Lines 17731 17726 -5 Branches 2682 2681 -1 =========================================== - Hits 14755 14684 -71 - Misses 2247 2310 +63 - Partials 729 732 +3 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2070?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [.../sessionreplay/internal/DefaultRecorderProvider.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2070?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2FDefaultRecorderProvider.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9EZWZhdWx0UmVjb3JkZXJQcm92aWRlci5rdA==) | `92.59% <100.00%> (+0.28%)` | :arrow_up: | | [...ionreplay/internal/recorder/mapper/ButtonMapper.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2070?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2Fmapper%2FButtonMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9tYXBwZXIvQnV0dG9uTWFwcGVyLmt0) | `72.73% <100.00%> (-14.77%)` | :arrow_down: | ... and [31 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2070/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)