DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
140 stars 56 forks source link

Remove some unused code from tracing module #2079

Closed 0xnm closed 3 weeks ago

0xnm commented 3 weeks ago

What does this PR do?

This PR removes some unused/impossible code from the tracing module:

This PR doesn't do a complete cleanup, just tries to address the simplest things.

Review checklist (to be filled by reviewers)

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (f2af2ad) to head (be68d62).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2079 +/- ## =========================================== + Coverage 67.46% 68.59% +1.13% =========================================== Files 735 719 -16 Lines 27002 26560 -442 Branches 4562 4468 -94 =========================================== + Hits 18215 18218 +3 + Misses 7569 7141 -428 + Partials 1218 1201 -17 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...og/opentracing/decorators/DDDecoratorsFactory.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Fopentracing%2Fdecorators%2FDDDecoratorsFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy9vcGVudHJhY2luZy9kZWNvcmF0b3JzL0RERGVjb3JhdG9yc0ZhY3RvcnkuamF2YQ==) | `50.00% <ø> (ø)` | | | [...ain/java/com/datadog/trace/api/ConfigDefaults.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fapi%2FConfigDefaults.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9hcGkvQ29uZmlnRGVmYXVsdHMuamF2YQ==) | `100.00% <ø> (ø)` | | | [...java/com/datadog/trace/api/InstrumenterConfig.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fapi%2FInstrumenterConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9hcGkvSW5zdHJ1bWVudGVyQ29uZmlnLmphdmE=) | `55.67% <100.00%> (+3.29%)` | :arrow_up: | | [.../src/main/java/com/datadog/trace/api/Platform.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fapi%2FPlatform.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9hcGkvUGxhdGZvcm0uamF2YQ==) | `45.45% <ø> (+0.50%)` | :arrow_up: | | [...ace/bootstrap/instrumentation/api/AgentTracer.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fbootstrap%2Finstrumentation%2Fapi%2FAgentTracer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9ib290c3RyYXAvaW5zdHJ1bWVudGF0aW9uL2FwaS9BZ2VudFRyYWNlci5qYXZh) | `8.11% <ø> (+0.46%)` | :arrow_up: | | [...adog/trace/common/writer/TraceStructureWriter.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcommon%2Fwriter%2FTraceStructureWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb21tb24vd3JpdGVyL1RyYWNlU3RydWN0dXJlV3JpdGVyLmphdmE=) | `47.83% <ø> (+3.38%)` | :arrow_up: | | [...c/main/java/com/datadog/trace/core/CoreTracer.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fcore%2FCoreTracer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9jb3JlL0NvcmVUcmFjZXIuamF2YQ==) | `71.53% <100.00%> (-0.14%)` | :arrow_down: | | [...ava/com/datadog/trace/util/AgentThreadFactory.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Futil%2FAgentThreadFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS91dGlsL0FnZW50VGhyZWFkRmFjdG9yeS5qYXZh) | `82.05% <100.00%> (-2.73%)` | :arrow_down: | | [.../src/main/java/com/datadog/trace/util/Strings.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Futil%2FStrings.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS91dGlsL1N0cmluZ3MuamF2YQ==) | `6.90% <ø> (+4.18%)` | :arrow_up: | | [...ce/src/main/java/com/datadog/trace/api/Config.java](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079?src=pr&el=tree&filepath=features%2Fdd-sdk-android-trace%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatadog%2Ftrace%2Fapi%2FConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtdHJhY2Uvc3JjL21haW4vamF2YS9jb20vZGF0YWRvZy90cmFjZS9hcGkvQ29uZmlnLmphdmE=) | `63.58% <50.00%> (+4.58%)` | :arrow_up: | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2079/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)