search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
150 stars 59 forks source link

RUM-4822 Allow monitoring internal connection pool #2105

Closed xgouchet closed 3 months ago

xgouchet commented 3 months ago

What does this PR do?

Adds a way for our customer to know the number of connections used by the internal OkHttpClient

[!NOTE] This will be part of a debug version of the SDK to help our customer regarding Incident 27794, and won't be merged into develop in the current state.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.82%. Comparing base (c2572e7) to head (341222a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/debug_incident_27794 #2105 +/- ## ================================================================ - Coverage 68.88% 68.82% -0.06% ================================================================ Files 709 710 +1 Lines 26311 26318 +7 Branches 4424 4425 +1 ================================================================ - Hits 18122 18112 -10 - Misses 6982 7000 +18 + Partials 1207 1206 -1 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2105?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...lin/com/datadog/android/core/ConnectionPoolInfo.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2105?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2FConnectionPoolInfo.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL0Nvbm5lY3Rpb25Qb29sSW5mby5rdA==) | `0.00% <0.00%> (ø)` | | | [...id/core/internal/data/upload/DataOkHttpUploader.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2105?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Fdata%2Fupload%2FDataOkHttpUploader.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL2RhdGEvdXBsb2FkL0RhdGFPa0h0dHBVcGxvYWRlci5rdA==) | `85.23% <0.00%> (-6.34%)` | :arrow_down: | ... and [30 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2105/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)