search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
140 stars 56 forks source link

RUM-3973: Session ended metric #2106

Closed ambushwork closed 2 weeks ago

ambushwork commented 2 weeks ago

What does this PR do?

Merge feature branch of "Session Ended Metric" into develop

Motivation

RUM-3973

Review checklist (to be filled by reviewers)

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.44944% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.64%. Comparing base (5197289) to head (3fb7239). Report is 27 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2106 +/- ## =========================================== - Coverage 68.73% 68.64% -0.09% =========================================== Files 719 721 +2 Lines 26571 26713 +142 Branches 4472 4501 +29 =========================================== + Hits 18262 18335 +73 - Misses 7123 7156 +33 - Partials 1186 1222 +36 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...rum/src/main/kotlin/com/datadog/android/rum/Rum.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2FRum.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9SdW0ua3Q=) | `92.16% <100.00%> (+0.49%)` | :arrow_up: | | [...d/rum/internal/domain/scope/RumApplicationScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fdomain%2Fscope%2FRumApplicationScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9kb21haW4vc2NvcGUvUnVtQXBwbGljYXRpb25TY29wZS5rdA==) | `94.68% <100.00%> (+0.18%)` | :arrow_up: | | [...droid/rum/internal/domain/scope/RumSessionScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fdomain%2Fscope%2FRumSessionScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9kb21haW4vc2NvcGUvUnVtU2Vzc2lvblNjb3BlLmt0) | `96.64% <100.00%> (+0.34%)` | :arrow_up: | | [.../android/rum/internal/domain/scope/RumViewScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fdomain%2Fscope%2FRumViewScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9kb21haW4vc2NvcGUvUnVtVmlld1Njb3BlLmt0) | `94.29% <100.00%> (-0.97%)` | :arrow_down: | | [.../android/rum/internal/monitor/DatadogRumMonitor.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmonitor%2FDatadogRumMonitor.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tb25pdG9yL0RhdGFkb2dSdW1Nb25pdG9yLmt0) | `86.12% <100.00%> (-1.22%)` | :arrow_down: | | [...ndroid/telemetry/internal/TelemetryEventHandler.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Ftelemetry%2Finternal%2FTelemetryEventHandler.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3RlbGVtZXRyeS9pbnRlcm5hbC9UZWxlbWV0cnlFdmVudEhhbmRsZXIua3Q=) | `83.57% <100.00%> (-0.16%)` | :arrow_down: | | [...d/rum/internal/domain/scope/RumViewManagerScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fdomain%2Fscope%2FRumViewManagerScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9kb21haW4vc2NvcGUvUnVtVmlld01hbmFnZXJTY29wZS5rdA==) | `94.41% <90.91%> (-0.33%)` | :arrow_down: | | [.../android/rum/internal/metric/SessionEndedMetric.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmetric%2FSessionEndedMetric.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tZXRyaWMvU2Vzc2lvbkVuZGVkTWV0cmljLmt0) | `93.55% <93.55%> (ø)` | | | [...um/internal/metric/SessionEndedMetricDispatcher.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmetric%2FSessionEndedMetricDispatcher.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tZXRyaWMvU2Vzc2lvbkVuZGVkTWV0cmljRGlzcGF0Y2hlci5rdA==) | `66.67% <66.67%> (ø)` | | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)