DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
140 stars 56 forks source link

RUM-5077: Fix units for dropped nodes #2107

Closed jonathanmos closed 2 weeks ago

jonathanmos commented 2 weeks ago

What does this PR do?

We're sending ns instead of ms in the error msg for dropped nodes, but still write "ms" in the message itself. This pr fixes the units in the message.

Motivation

Wrong units in the dropped nodes error.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (develop@df0670f). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2107 +/- ## ========================================== Coverage ? 69.18% ========================================== Files ? 700 Lines ? 26165 Branches ? 4406 ========================================== Hits ? 18101 Misses ? 6864 Partials ? 1200 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2107?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...nreplay/internal/async/RecordedDataQueueHandler.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2107?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Fasync%2FRecordedDataQueueHandler.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9hc3luYy9SZWNvcmRlZERhdGFRdWV1ZUhhbmRsZXIua3Q=) | `97.50% <ø> (ø)` | |