search

DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
140 stars 56 forks source link

Revert "Add sampling rate to internal metrics" #2112

Closed xgouchet closed 1 week ago

xgouchet commented 1 week ago

Reverts DataDog/dd-sdk-android#2108

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.56%. Comparing base (d2a5741) to head (d8d0838).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2112 +/- ## =========================================== - Coverage 69.84% 69.56% -0.28% =========================================== Files 715 715 Lines 26577 26553 -24 Branches 4457 4452 -5 =========================================== - Hits 18561 18469 -92 - Misses 6821 6871 +50 - Partials 1195 1213 +18 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...n/kotlin/com/datadog/android/api/InternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fapi%2FInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9hcGkvSW50ZXJuYWxMb2dnZXIua3Q=) | `100.00% <ø> (ø)` | | | [.../android/core/internal/logger/SdkInternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Flogger%2FSdkInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL2xvZ2dlci9TZGtJbnRlcm5hbExvZ2dlci5rdA==) | `86.73% <ø> (-7.20%)` | :arrow_down: | | [...id/core/internal/metrics/BatchMetricsDispatcher.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Fmetrics%2FBatchMetricsDispatcher.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL21ldHJpY3MvQmF0Y2hNZXRyaWNzRGlzcGF0Y2hlci5rdA==) | `98.61% <100.00%> (-0.04%)` | :arrow_down: | | [...oid/core/internal/metrics/MethodCalledTelemetry.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Fmetrics%2FMethodCalledTelemetry.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL21ldHJpY3MvTWV0aG9kQ2FsbGVkVGVsZW1ldHJ5Lmt0) | `100.00% <100.00%> (ø)` | | | [...dog/android/core/metrics/MethodCallSamplingRate.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Fmetrics%2FMethodCallSamplingRate.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL21ldHJpY3MvTWV0aG9kQ2FsbFNhbXBsaW5nUmF0ZS5rdA==) | `0.00% <ø> (-100.00%)` | :arrow_down: | | [...d/rum/internal/domain/scope/RumViewManagerScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fdomain%2Fscope%2FRumViewManagerScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9kb21haW4vc2NvcGUvUnVtVmlld01hbmFnZXJTY29wZS5rdA==) | `94.41% <100.00%> (+0.61%)` | :arrow_up: | | [...um/internal/metric/SessionEndedMetricDispatcher.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmetric%2FSessionEndedMetricDispatcher.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tZXRyaWMvU2Vzc2lvbkVuZGVkTWV0cmljRGlzcGF0Y2hlci5rdA==) | `66.67% <100.00%> (-1.08%)` | :arrow_down: | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2112/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)