DataDog / dd-sdk-android

Datadog SDK for Android (Compatible with Kotlin and Java)
Apache License 2.0
140 stars 56 forks source link

Add sampling rate to internal metrics #2113

Closed xgouchet closed 1 week ago

xgouchet commented 1 week ago

What does this PR do?

[!NOTE] This metric will be applied in addition to the telemetry sampling rate, so if a logMetric is created with a sampling rate of 10%, with the global telemetry sampling rate being sampled at 20%, it has a 2% chance of being kept.

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.49%. Comparing base (f1f0255) to head (d377ef1). Report is 9 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2113 +/- ## =========================================== + Coverage 69.48% 69.49% +0.01% =========================================== Files 715 715 Lines 26550 26577 +27 Branches 4454 4452 -2 =========================================== + Hits 18446 18468 +22 Misses 6890 6890 - Partials 1214 1219 +5 ``` | [Files](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...n/kotlin/com/datadog/android/api/InternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fapi%2FInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9hcGkvSW50ZXJuYWxMb2dnZXIua3Q=) | `100.00% <ø> (ø)` | | | [.../android/core/internal/logger/SdkInternalLogger.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Flogger%2FSdkInternalLogger.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL2xvZ2dlci9TZGtJbnRlcm5hbExvZ2dlci5rdA==) | `86.87% <100.00%> (-7.01%)` | :arrow_down: | | [...id/core/internal/metrics/BatchMetricsDispatcher.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Fmetrics%2FBatchMetricsDispatcher.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL21ldHJpY3MvQmF0Y2hNZXRyaWNzRGlzcGF0Y2hlci5rdA==) | `98.65% <100.00%> (+2.82%)` | :arrow_up: | | [...oid/core/internal/metrics/MethodCalledTelemetry.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Finternal%2Fmetrics%2FMethodCalledTelemetry.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL2ludGVybmFsL21ldHJpY3MvTWV0aG9kQ2FsbGVkVGVsZW1ldHJ5Lmt0) | `100.00% <100.00%> (ø)` | | | [...dog/android/core/metrics/MethodCallSamplingRate.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=dd-sdk-android-core%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fcore%2Fmetrics%2FMethodCallSamplingRate.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZGQtc2RrLWFuZHJvaWQtY29yZS9zcmMvbWFpbi9rb3RsaW4vY29tL2RhdGFkb2cvYW5kcm9pZC9jb3JlL21ldHJpY3MvTWV0aG9kQ2FsbFNhbXBsaW5nUmF0ZS5rdA==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [...um/internal/metric/SessionEndedMetricDispatcher.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fmetric%2FSessionEndedMetricDispatcher.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9tZXRyaWMvU2Vzc2lvbkVuZGVkTWV0cmljRGlzcGF0Y2hlci5rdA==) | `67.74% <100.00%> (+1.08%)` | :arrow_up: | | [...internal/recorder/DefaultOnDrawListenerProducer.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=features%2Fdd-sdk-android-session-replay%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Fsessionreplay%2Finternal%2Frecorder%2FDefaultOnDrawListenerProducer.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtc2Vzc2lvbi1yZXBsYXkvc3JjL21haW4va290bGluL2NvbS9kYXRhZG9nL2FuZHJvaWQvc2Vzc2lvbnJlcGxheS9pbnRlcm5hbC9yZWNvcmRlci9EZWZhdWx0T25EcmF3TGlzdGVuZXJQcm9kdWNlci5rdA==) | `36.36% <0.00%> (ø)` | | | [...d/rum/internal/domain/scope/RumViewManagerScope.kt](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113?src=pr&el=tree&filepath=features%2Fdd-sdk-android-rum%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fdatadog%2Fandroid%2Frum%2Finternal%2Fdomain%2Fscope%2FRumViewManagerScope.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZmVhdHVyZXMvZGQtc2RrLWFuZHJvaWQtcnVtL3NyYy9tYWluL2tvdGxpbi9jb20vZGF0YWRvZy9hbmRyb2lkL3J1bS9pbnRlcm5hbC9kb21haW4vc2NvcGUvUnVtVmlld01hbmFnZXJTY29wZS5rdA==) | `90.67% <45.45%> (-3.74%)` | :arrow_down: | ... and [38 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-sdk-android/pull/2113/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)