search

DataDog / dd-sdk-flutter

Flutter bindings and tools for utilizing Datadog Mobile SDKs
Apache License 2.0
41 stars 40 forks source link

[iOS] Variant doesn't appear to be applied to logs #568

Closed ellis-cot closed 3 months ago

ellis-cot commented 4 months ago

Describe the bug

Since symbolication appears to use the variant to find the correct symbols, this causes "Symbolication failed" errors for logs with stack traces.

We're obfuscating our build and uploading the symbols/maps with the --flavor argument as recommended here: https://docs.datadoghq.com/real_user_monitoring/error_tracking/mobile/flutter/#advanced-configuration---flavors-and-build-numbers. We also supply the flavor parameter to the DatadogConfiguration object.

Android logs are tagged with the variant and are symbolicated correctly, we get an error message for iOS logs.

Reproduction steps

Obfuscate a build and upload the symbols with the --flavor parameter. Initialise the DataDog SDK instance with flavor set. Create a log that includes a stack trace. See if the log has been symbolicated.

SDK logs

No response

Expected behavior

Stack traces are symbolicated and the logs are tagged with the variant

Affected SDK versions

2.2.0

Latest working SDK version

No response

Did you confirm if the latest SDK version fixes the bug?

Yes

Flutter Version

3.16.5

Setup Type

Flutter application

Device Information

iOS

Other relevant information

No response

fuzzybinary commented 4 months ago

Hi @ellis-cot,

Thanks for reporting. This does seem to be the case. I'll need to add variant reporting to the iOS SDK and I'll release a fix to Flutter ASAP.

Sorry for the inconvenience!

ellis-cot commented 4 months ago

Marvellous, thanks for the swift response @fuzzybinary

fuzzybinary commented 3 months ago

This should now be available in 2.4.0. Please let me know if you see any issues.