search

DataDog / dd-sdk-flutter

Flutter bindings and tools for utilizing Datadog Mobile SDKs
Apache License 2.0
41 stars 40 forks source link

feat: add ignoreUrlPatterns to TrackingExtensionExisting #613

Closed 4rthurmonteiro closed 1 month ago

4rthurmonteiro commented 1 month ago

ISSUE: https://github.com/DataDog/dd-sdk-flutter/issues/614

What and why?

To filter http tracking when using Flutter module.

What changes does this pull request introduce and why is it necessary?

Add ignoreUrlPatterns to TrackingExtensionExisting extension

How?

Adding in enableHttpTracking the attribute ignoreUrlPatterns.

If needed, a description of how this PR accomplishes what it does.

Review checklist

4rthurmonteiro commented 1 month ago

@fuzzybinary why did bitrise check fail?

fuzzybinary commented 1 month ago

@4rthurmonteiro It doesn't run unless we approve it for security reasons.

fuzzybinary commented 1 month ago

also nit: this is a feature, not a chore.

4rthurmonteiro commented 1 month ago

also nit: this is a feature, not a chore.

changed!

4rthurmonteiro commented 1 month ago

@fuzzybinary i updated the example.

4rthurmonteiro commented 1 month ago

@4rthurmonteiro Sorry a few more minor requests.

First, We require all commits to be signed. Would you be able to do that and re-open? If not I can make the changes and get them in.

Second, can you add an item to the CHANGELOG?

Ok, i will reopen. Thanks @fuzzybinary