RUM-4079 chore: Do not block CI pipeline with dogfooding jobs - Githubissues

DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.

Apache License 2.0

219 stars 127 forks source link

RUM-4079 chore: Do not block CI pipeline with dogfooding jobs #1965

Closed ncreated closed 3 months ago

ncreated commented 3 months ago

What and why?

📦 Fixes the problem of blocking CI pipeline for develop when manual Dogfooding jobs are added (since https://github.com/DataDog/dd-sdk-ios/pull/1961).

Expected behaviorus are:

The develop pipeline is not blocked by awaiting manual jobs to be ran.
The failures of Dogfooding jobs should not alter the state of develop commit integration (such should be only determined from default integration stages like tests, ui-tests and smoke-tests).

How?

Using rules:allow_failure:true:

Use allow_failure: true in rules to allow a job to fail without stopping the pipeline.

You can also use allow_failure: true with a manual job. The pipeline continues running without waiting for the result of the manual job.

Without customizing allow_failure, the pipeline uses default (false), which was causing the whole pipeline to wait:

allow_failure: false combined with when: manual in rules causes the pipeline to wait for the manual job to run before continuing.

Review checklist

[ ] Feature or bugfix MUST have appropriate tests (unit, integration)
[ ] Make sure each commit and the PR mention the Issue number or JIRA reference
[ ] Add CHANGELOG entry for user facing changes