DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.
Apache License 2.0
219 stars 127 forks source link

RUM-5752 Benchmarks: UIKit catalog for Session Replay scenario #2001

Closed maxep closed 2 months ago

maxep commented 2 months ago

What and why?

Integrate the UIKitCatalog to be used for Session Replay scenario.

Simulator Screenshot - iPhone 15 Pro - 2024-08-21 at 10 26 47 Simulator Screenshot - iPhone 15 Pro - 2024-08-21 at 10 28 42 Simulator Screenshot - iPhone 15 Pro - 2024-08-21 at 10 28 45 Simulator Screenshot - iPhone 15 Pro - 2024-08-21 at 10 29 02

How?

Note for reviewers: No need to review UIKitCatalog sources, it's coming from Apple's sample code: UIKitCatalog. Only SessionReplayScenario.swift and pbxproj were modified.

Review checklist

maxep commented 2 months ago

@ncreated

How will the navigation through this UI be solved during benchmark run? Do we plan to create synthetics test that will use UIAutomation to navigate through this UI 🤔?

Yes, the navigation in scenario will be defined in a Synthetic Test in Mobile - Integration org.

I'm totally up for reusing the UIKitCatalog in SRSnapshotTests and E2ETests, I transformed it to a framework so we can easily migrate it to a reusable package. But lets move it there when we have a need for it, WDYT?

ncreated commented 2 months ago

@ncreated

How will the navigation through this UI be solved during benchmark run? Do we plan to create synthetics test that will use UIAutomation to navigate through this UI 🤔?

Yes, the navigation in scenario will be defined in a Synthetic Test in Mobile - Integration org.

I see 👍, thanks for clarifying. I have some thoughts on this, but it is not blocking this PR defintely!

I'm totally up for reusing the UIKitCatalog in SRSnapshotTests and E2ETests, I transformed it to a framework so we can easily migrate it to a reusable package. But lets move it there when we have a need for it, WDYT?

Totally 👌, it's separate work to be done when we need it 🙂!