Fix lazy image SR identifier

DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.

Apache License 2.0

219 stars 127 forks source link

Fix lazy image SR identifier #2013

Closed maciejburda closed 2 months ago

maciejburda commented 2 months ago

What and why?

While working on the configuration we have discovered that lazy identifier for UIImages in Session Replay doesn't work.

Mitigation is simple. When introducing DatadogExtension instead of direct extension we forget to change the object that maintains associated objects.

This is hard to test. We could potentially measure the time. Second time should be way faster than the first one, but it has a risk of being flaky.

Review checklist

[ ] Feature or bugfix MUST have appropriate tests (unit, integration)
[ ] Make sure each commit and the PR mention the Issue number or JIRA reference
[ ] Add CHANGELOG entry for user facing changes

datadog-datadog-prod-us1[bot] commented 2 months ago

Datadog Report

Branch report: maciey/fix-lazy-image-sridentifier Commit report: b1929a4 Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 1863 Passed, 0 Skipped, 1m 14.98s Total Time :small_red_triangle_down: Test Sessions change in coverage: 2 decreased, 6 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (2)

test DatadogInternalTests iOS 79.59% (-0.02%) - Details
test DatadogCrashReportingTests iOS 26.6% (-0.02%) - Details