RUM-5083 chore: Lower Batch Metrics sample rate to 10% of its original value

DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.

Apache License 2.0

219 stars 127 forks source link

RUM-5083 chore: Lower Batch Metrics sample rate to 10% of its original value #2016

Closed ncreated closed 2 months ago

ncreated commented 2 months ago

What and why?

📦 This PR lowers the sample rate for "Batch Deleted" and "Batch Closed" metrics from 15% to 1.5%.

Counterpart of https://github.com/DataDog/dd-sdk-android/pull/2146

How?

Leveraging metric-specific sample rate configuration added in https://github.com/DataDog/dd-sdk-ios/pull/2015, this PR changes sampleRate in batch metrics from default 15% to custom 1.5%.

Review checklist

[x] Feature or bugfix MUST have appropriate tests (unit, integration)
[x] Make sure each commit and the PR mention the Issue number or JIRA reference
[ ] Add CHANGELOG entry for user facing changes

datadog-datadog-prod-us1[bot] commented 2 months ago

Datadog Report

Branch report: ncreated/RUM-5083/batch-metric-sampling Commit report: 4f39eaf Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 1860 Passed, 0 Skipped, 1m 17.74s Total Time :small_red_triangle_down: Test Sessions change in coverage: 2 decreased, 3 increased, 3 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (2)

test DatadogLogsTests iOS 45.37% (-1.39%) - Details
test DatadogTraceTests iOS 54.26% (-0.06%) - Details