RUM-5841 feat: setup addViewLoadingTime usage telemetry

DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.

Apache License 2.0

205 stars 123 forks source link

RUM-5841 feat: setup addViewLoadingTime usage telemetry #2022

Closed ganeshnj closed 1 month ago

ganeshnj commented 1 month ago

What and why?

We want to use usage telemetry to trace the addViewLoadingTime usage.

How?

There are different cases we want to track per https://datadoghq.atlassian.net/wiki/spaces/RUMP/pages/3951001790/RFC+View+loading+time+manual+API

when API is used
when there is no view to report
when there is a view but not active
when there is view, active and already has the timing

Review checklist

[x] Feature or bugfix MUST have appropriate tests (unit, integration)
[x] Make sure each commit and the PR mention the Issue number or JIRA reference
[ ] Add CHANGELOG entry for user facing changes

datadog-datadog-prod-us1[bot] commented 1 month ago

Datadog Report

Branch report: ganeshnj/feat/add-view-loading-time-usage-telemetry Commit report: 8856f08 Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 1866 Passed, 0 Skipped, 1m 15.81s Total Time :small_red_triangle_down: Test Sessions change in coverage: 4 decreased, 3 increased, 1 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (4)

test DatadogRUMTests iOS 81.13% (-0.63%) - Details
test DatadogCoreTests iOS 72.78% (-0.39%) - Details
test DatadogSessionReplayTests iOS 30.22% (-0.25%) - Details
test DatadogLogsTests iOS 46.74% (-0.02%) - Details

maciejburda commented 1 month ago

Seems like it's missing some changes.

I'm only seeing RUM model regenerated

ganeshnj commented 1 month ago

Closing in favor of https://github.com/DataDog/dd-sdk-ios/pull/2022