DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.
Apache License 2.0
205 stars 123 forks source link

RUM 5764 [SR] Deprecate former SessionReplay Configuration API #2023

Closed mariedm closed 4 weeks ago

mariedm commented 1 month ago

What and why?

As part of the Fine Grained Masking (FGM) initiative (RFC), we are transitioning from a single PrivacyLevel to three distinct privacy levels: textAndInputPrivacyLevel, imagePrivacyLevel, and touchPrivacyLevel.

We now have a new API to create a Session Replay (SR) configuration using these new privacy levels, allowing us to deprecate the previous API.

How?

As part of this deprecation, we now rely on new privacy levels instead of PrivacyLevel.

This PR:

Notes

1) File Changes: Don't be frightened by the number of changed files; 70% are related to snapshot test updates.

2) Options and behavior of PrivacyLevel before FGM:

For images, non-bundled images are hidden on iOS, and large images are hidden on Android. Touches are always shown by default.

Moving forward, by converting PrivacyLevel to new privacy levels, the behavior will be slightly modified to the following:

Review checklist

datadog-datadog-prod-us1[bot] commented 1 month ago

Datadog Report

Branch report: RUM-5764-deprecate-former-api Commit report: a6f9a61 Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 1880 Passed, 0 Skipped, 1m 15.28s Total Time :small_red_triangle_down: Test Sessions change in coverage: 4 decreased, 2 increased, 2 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (4)