DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.
Apache License 2.0
219 stars 127 forks source link

chore: Extend app launch handler to macCatalyst and visionOS #2033

Closed ncreated closed 2 months ago

ncreated commented 2 months ago

What and why?

QA and merge https://github.com/DataDog/dd-sdk-ios/pull/1888 by @Hengyu

How?

Using internal branch to merge https://github.com/DataDog/dd-sdk-ios/pull/1888

TARGET_OS_MAC                - Generated code will run on a variant of macOS
  TARGET_OS_OSX                - Generated code will run on macOS
  TARGET_OS_IPHONE             - Generated code will run on a variant of iOS (firmware, devices, simulator)
    TARGET_OS_IOS                - Generated code will run on iOS
      TARGET_OS_MACCATALYST        - Generated code will run on macOS
    TARGET_OS_TV                 - Generated code will run on tvOS
    TARGET_OS_WATCH              - Generated code will run on watchOS
    TARGET_OS_VISION             - Generated code will run on visionOS
    TARGET_OS_BRIDGE             - Generated code will run on bridge devices
  TARGET_OS_SIMULATOR          - Generated code will run on an iOS, tvOS, watchOS, or visionOS simulator
  TARGET_OS_DRIVERKIT          - Generated code will run on macOS, iOS, tvOS, watchOS, or visionOS

+--------------------------------------------------------------------------------------+
|                                    TARGET_OS_MAC                                     |
| +-----+ +------------------------------------------------------------+ +-----------+ |
| |     | |                  TARGET_OS_IPHONE                          | |           | |
| |     | | +-----------------+ +----+ +-------+ +--------+ +--------+ | |           | |
| |     | | |       IOS       | |    | |       | |        | |        | | |           | |
| | OSX | | | +-------------+ | | TV | | WATCH | | BRIDGE | | VISION | | | DRIVERKIT | |
| |     | | | | MACCATALYST | | |    | |       | |        | |        | | |           | |
| |     | | | +-------------+ | |    | |       | |        | |        | | |           | |
| |     | | +-----------------+ +----+ +-------+ +--------+ +--------+ | |           | |
| +-----+ +------------------------------------------------------------+ +-----------+ |
+--------------------------------------------------------------------------------------+

Review checklist

datadog-datadog-prod-us1[bot] commented 2 months ago

Datadog Report

Branch report: ncreated/merge-hengyu-enhance-macro-usage- Commit report: d4df1c5 Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 1869 Passed, 0 Skipped, 1m 17.36s Total Time :small_red_triangle_down: Test Sessions change in coverage: 2 decreased, 6 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (2)

ncreated commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in develop is 0s.

Use /merge -c to cancel this operation!

ncreated commented 2 months ago

/remove

dd-devflow[bot] commented 2 months ago

:steam_locomotive: Devflow: /remove

dd-devflow[bot] commented 2 months ago

:warning: MergeQueue: This merge request build was cancelled

This merge request build was cancelled

If you need support, contact us on Slack #devflow!