DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.
Apache License 2.0
205 stars 123 forks source link

Add background upload configuration info to batch deleted telemetry #2039

Open maciejburda opened 3 weeks ago

maciejburda commented 3 weeks ago

What and why?

Enriches Batch Deleted telemetry metric with backgroundTaskEnabled configuration info. This is needed for measuring batch delivery success rate based on existence of the configuration.

How?

I have found unused field in_background which was hardcoded to false, and passed the configuration value to it.

Now, we might consider following:

Although after some deliberation I realized that we're mostly interested in measuring the difference is success rate for two different configurations, rather than knowing if batch file was deleted in background/foreground.

Looking for some feedback on that 🙌

Review checklist

datadog-datadog-prod-us1[bot] commented 3 weeks ago

Datadog Report

Branch report: maciey/add-backgroundtask-telemetry Commit report: 2510312 Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 1869 Passed, 0 Skipped, 1m 14.71s Total Time :arrow_up: Test Sessions change in coverage: 3 increased, 5 no change