DataDog / dd-sdk-ios

Datadog SDK for iOS - Swift and Objective-C.
Apache License 2.0
219 stars 127 forks source link

RUM-872 Keep Secured Text Hidden #2050

Closed maxep closed 2 months ago

maxep commented 2 months ago

What and why?

UITextInputTraits's isSecureTextEntry and textContentType properties are mutable, meaning that a sensitive texts could be revealed to the end user. e.g.: Revealing a password for verification.

But in Session Replay, we should keep considering the text as sensitive even if it was revealed.

How?

Keep sensitivity in memory using associated object on views conforming to UITextInputTraits.

Review checklist

datadog-datadog-prod-us1[bot] commented 2 months ago

Datadog Report

Branch report: maxep/RUM-872/keep-secure-fields-hidden Commit report: cba150d Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 3470 Passed, 0 Skipped, 2m 18.44s Total Time :small_red_triangle_down: Test Sessions change in coverage: 3 decreased, 4 increased, 7 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (3)