DataDog / dd-sdk-reactnative

Datadog SDK for ReactNative
Apache License 2.0
122 stars 42 forks source link

2.4.2 build on android error #707

Closed wcastand closed 4 months ago

wcastand commented 4 months ago

Describe the bug

when i try to build my expo app with the latest release on android i get this:

> Task :datadog_mobile-react-native:compileDebugKotlin FAILED
e: file:///Volumes/dev/retails/node_modules/@datadog/mobile-react-native/android/src/main/kotlin/com/datadog/reactnative/FrameRateProvider.kt:43:24 Unresolved reference: postFrameCallback
e: file:///Volumes/dev/retails/node_modules/@datadog/mobile-react-native/android/src/main/kotlin/com/datadog/reactnative/FrameRateProvider.kt:48:49 Unresolved reference: getInstance
e: file:///Volumes/dev/retails/node_modules/@datadog/mobile-react-native/android/src/main/kotlin/com/datadog/reactnative/FrameRateProvider.kt:49:28 Unresolved reference: postFrameCallback
e: file:///Volumes/dev/retails/node_modules/@datadog/mobile-react-native/android/src/main/kotlin/com/datadog/reactnative/FrameRateProvider.kt:55:49 Unresolved reference: getInstance
e: file:///Volumes/dev/retails/node_modules/@datadog/mobile-react-native/android/src/main/kotlin/com/datadog/reactnative/FrameRateProvider.kt:56:28 Unresolved reference: removeFrameCallback

FAILURE: Build failed with an exception.

Reproduction steps

install "@datadog/mobile-react-native": "^2.4.2", and try to build android app

SDK logs

No response

Expected behavior

be able to build the android app

Affected SDK versions

2.4.2

Latest working SDK version

2.4.1

Did you confirm if the latest SDK version fixes the bug?

No

Integration Methods

Source

React Native Version

0.73.3

Package.json Contents

No response

iOS Setup

No response

Android Setup

No response

Device Information

No response

Other relevant information

seems to be related to FramerateProvider added in 2.4.2

RamboWasReal commented 4 months ago

same error

AlbertHernandez commented 4 months ago

Same here, using 2.4.1 works fine

marco-saia-datadog commented 4 months ago

@wcastand @RamboWasReal @AlbertHernandez

Hello 👋 Thank you for reaching out!

Can you please share your package.json? I am particularly interested in your Expo and React Native packages versions.

wcastand commented 4 months ago

expo: ~51.0.22 react-native": 0.74.3

short-dsb commented 4 months ago

This is also happening outside of Expo with React Native v0.74.3.

bhandanyan-nomad commented 4 months ago

Same here, no expo RN v0.74

malavshah9 commented 4 months ago

Same here with

    "expo": "^51.0.0",
    "react-native": "0.74.3",
dhleeOfficial commented 4 months ago

any update?

MichaelPeterJoyce commented 4 months ago

Same issue

AlexLFundbox commented 4 months ago

Same here, no expo, RN v0.74.3

MathiasLimaCompass commented 4 months ago

We had to move to version 2.1.0 to resolve @wcastand

"@datadog/mobile-react-native": "2.1.0", "@datadog/mobile-react-navigation": "2.1.0",

"react-native": "0.74.3",
wcastand commented 4 months ago

was working fine for me until 2.4.2, even 2.4.1 why did you go so far back? we are on expo router so we don't use react-navigation packages directly at least.

dconlisk commented 4 months ago

Same issue. Downgrading to 2.4.1 worked for us, very grateful for this issue being raised!

AlbertHernandez commented 4 months ago

Hi @marco-saia-datadog, I am using react native 0.74.3, expo 51.0.22

marco-saia-datadog commented 4 months ago

Thank you for reaching out, we are addressing the issue in v2.4.3. We can confirm that downgrading to 2.4.1 will solve the issue as for now. We apologise for the inconvenience!

marco-saia-datadog commented 4 months ago

Hey 👋 😃

Version v2.4.3 has been released! Thank you for your patience :)

hroland commented 2 months ago

hi @marco-saia-datadog! experiencing the same kotlin build error under:

"expo": "51.0.32",
"react-native": "0.75.2"

whats the recommended expo/RN version for v2.4.3?