DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
449 stars 141 forks source link

Instrument StandardSocketsHttpHandler #3139

Open NishantAgrawalTR opened 2 years ago

NishantAgrawalTR commented 2 years ago

Are you requesting automatic instrumentation for a framework or library? Please describe.

Framework or library name : StandardSocketsHttpHandler https://github.com/TalAloni/StandardSocketsHttpHandler

Is your feature request related to a problem? Please describe. There's no auto instrumentation for StandardSocketsHttpHandler and we would like to utilize this class over the existing ones (System.Net.Http.HttpClientHandler & System.Net.Http.HttpMessageHandler). The StandardSocketsHttpHandler is a port of System.Net.Http.SocketsHttpHandler for .NET Standard/Framework.

Describe the solution you'd like Similar auto instrumentation for StandardSocketsHttpHandler similar to one in Instrument System.Net.Http.SocketsHttpHandler #668

pierotibou commented 2 years ago

Hello @NishantAgrawalTR, We haven't planned any work on this. That said, I'll look into whether we could prioritise instrumenting HttpMessageHandler abstract class instead which would solve this one as well. Scratch that, this solution would be way to noisy. We'll need to prioritize this use case specifically. And I can't commit on anything for now unfortunately.