Closed kevingosse closed 1 week ago
datadog-ddstaging[bot]
commented
2 weeks ago Branch report: kevin/BLockingMiddleware
Commit report: 2334263
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 339263 Passed, 1668 Skipped, 14h 8m 27.96s Total Time
andrewlock
commented
2 weeks ago Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5708) - mean (73ms) : 64, 82
. : milestone, 73,
master - mean (73ms) : 66, 80
. : milestone, 73,
section CallTarget+Inlining+NGEN
This PR (5708) - mean (1,010ms) : 985, 1036
. : milestone, 1010,
master - mean (1,010ms) : 990, 1029
. : milestone, 1010,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5708) - mean (110ms) : 103, 117
. : milestone, 110,
master - mean (109ms) : 105, 113
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5708) - mean (716ms) : 693, 740
. : milestone, 716,
master - mean (712ms) : 690, 735
. : milestone, 712,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5708) - mean (94ms) : 89, 98
. : milestone, 94,
master - mean (92ms) : 90, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5708) - mean (676ms) : 654, 699
. : milestone, 676,
master - mean (669ms) : 646, 691
. : milestone, 669,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5708) - mean (191ms) : 188, 195
. : milestone, 191,
master - mean (191ms) : 187, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (5708) - mean (1,097ms) : 1076, 1119
. : milestone, 1097,
master - mean (1,099ms) : 1078, 1121
. : milestone, 1099,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5708) - mean (276ms) : 272, 281
. : milestone, 276,
master - mean (276ms) : 272, 279
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5708) - mean (896ms) : 869, 922
. : milestone, 896,
master - mean (899ms) : 874, 925
. : milestone, 899,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5708) - mean (266ms) : 261, 271
. : milestone, 266,
master - mean (265ms) : 260, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5708) - mean (884ms) : 861, 908
. : milestone, 884,
master - mean (878ms) : 854, 903
. : milestone, 878,
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5708) (11.646M) : 0, 11646044
master (11.467M) : 0, 11467451
benchmarks/2.9.0 (11.627M) : 0, 11626549
section Automatic
This PR (5708) (7.795M) : 0, 7794976
master (7.819M) : 0, 7818988
benchmarks/2.9.0 (8.152M) : 0, 8152375
section Trace stats
master (8.140M) : 0, 8140060
section Manual
This PR (5708) (9.880M) : 0, 9879611
master (9.975M) : 0, 9974750
section Manual + Automatic
This PR (5708) (7.283M) : 0, 7282902
master (7.387M) : 0, 7386599
section Version Conflict
master (6.632M) : 0, 6632104
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5708) (9.670M) : 0, 9669651
master (9.629M) : 0, 9628629
benchmarks/2.9.0 (9.556M) : 0, 9555681
section Automatic
This PR (5708) (6.589M) : 0, 6588558
master (6.711M) : 0, 6711415
section Trace stats
master (6.840M) : 0, 6840450
section Manual
This PR (5708) (8.443M) : 0, 8443037
master (8.172M) : 0, 8171953
section Manual + Automatic
This PR (5708) (6.241M) : 0, 6240866
master (6.214M) : 0, 6214343
section Version Conflict
master (5.654M) : 0, 5653941
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5708) (9.969M) : 0, 9968633
master (10.241M) : 0, 10240922
benchmarks/2.9.0 (10.130M) : 0, 10129519
section Automatic
This PR (5708) (7.056M) : 0, 7056345
master (7.331M) : 0, 7330628
benchmarks/2.9.0 (7.456M) : 0, 7456006
section Trace stats
master (7.533M) : 0, 7532511
section Manual
This PR (5708) (8.744M) : 0, 8744100
master (8.939M) : 0, 8939388
section Manual + Automatic
This PR (5708) (6.767M) : 0, 6767347
master (7.039M) : 0, 7038915
section Version Conflict
master (6.288M) : 0, 6287948
Benchmarks for #5708 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Summary of changes
Change the heuristic to look for
BlockingMiddlewareanywhere in the type, when deciding if we caused the crash.Reason for change
The previous condition failed to filter
Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNetCore.BlockingMiddleware+<Invoke>d__5.MoveNext.Implementation details
s/EndsWith/Contains