search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
413 stars 132 forks source link

Config refactor - support "converters" for other configuration types #5714

Closed andrewlock closed 4 days ago

andrewlock commented 1 week ago

Summary of changes

Allow providing additional "converters" for types other than the generic T, such as int and bool

Reason for change

The otel-specific code introduced in https://github.com/DataDog/dd-trace-dotnet/pull/5661 requires performing non-standard conversions to some primitive types. For example, for a bool the required values might be "none"=true, which requires using GetAs<> to handle the conversion.

This PR adds additional overloads so that you can call GetAsBool which makes the usages more obvious (and simplifies some things in subsequent PRs)

Implementation details

Add additional, optional, "converter" arguments (Func<string, ParsingResult<bool>>) to the methods that don't already have them

Test coverage

Add unit tests for the new conversion behaviour

Other details

This is part of a big stack of config refactoring PRs:

datadog-ddstaging[bot] commented 1 week ago

Datadog Report

Branch report: andrew/config-refactor/2-extra-converters Commit report: 811d98d Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 343490 Passed, 1661 Skipped, 13h 51m 0.22s Total Time

andrewlock commented 1 week ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5714) - mean (74ms)  : 64, 83
     .   : milestone, 74,
    master - mean (76ms)  : 63, 89
     .   : milestone, 76,

    section CallTarget+Inlining+NGEN
    This PR (5714) - mean (995ms)  : 977, 1013
     .   : milestone, 995,
    master - mean (994ms)  : 970, 1017
     .   : milestone, 994,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5714) - mean (109ms)  : 105, 113
     .   : milestone, 109,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5714) - mean (701ms)  : 679, 722
     .   : milestone, 701,
    master - mean (703ms)  : 681, 724
     .   : milestone, 703,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5714) - mean (93ms)  : 90, 95
     .   : milestone, 93,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5714) - mean (656ms)  : 632, 679
     .   : milestone, 656,
    master - mean (655ms)  : 639, 672
     .   : milestone, 655,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5714) - mean (192ms)  : 188, 196
     .   : milestone, 192,
    master - mean (191ms)  : 186, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5714) - mean (1,101ms)  : 1080, 1123
     .   : milestone, 1101,
    master - mean (1,082ms)  : 1059, 1106
     .   : milestone, 1082,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5714) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (277ms)  : 269, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5714) - mean (881ms)  : 852, 910
     .   : milestone, 881,
    master - mean (878ms)  : 846, 910
     .   : milestone, 878,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5714) - mean (266ms)  : 261, 271
     .   : milestone, 266,
    master - mean (266ms)  : 261, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5714) - mean (871ms)  : 846, 896
     .   : milestone, 871,
    master - mean (861ms)  : 840, 882
     .   : milestone, 861,
andrewlock commented 1 week ago

Benchmarks Report for tracer :snail:

Benchmarks for #5714 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartStopWithChild`|net6.0|7.63μs|41.4ns|248ns|0.0151| 0.00756|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartStopWithChild`|netcoreapp3.1|9.91μs|50.4ns|294ns|0.0247| 0.00988|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartStopWithChild`|net472|16.2μs|29.5ns|102ns|1.01| 0.301|0.0871|6.06 KB| |#5714|`StartStopWithChild`|net6.0|7.72μs|43.1ns|286ns|0.0156| 0.0078|0|5.43 KB| |#5714|`StartStopWithChild`|netcoreapp3.1|9.71μs|53.2ns|315ns|0.0201| 0.0101|0|5.62 KB| |#5714|`StartStopWithChild`|net472|16.1μs|70.8ns|274ns|1| 0.299|0.089|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net6.0|484μs|271ns|1.01μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|645μs|176ns|636ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net472|827μs|234ns|905ns|0.411| 0|0|3.3 KB| |#5714|`WriteAndFlushEnrichedTraces`|net6.0|505μs|278ns|1.08μs|0| 0|0|2.7 KB| |#5714|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|633μs|450ns|1.74μs|0| 0|0|2.7 KB| |#5714|`WriteAndFlushEnrichedTraces`|net472|825μs|390ns|1.51μs|0.411| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendRequest`|net6.0|173μs|179ns|695ns|0.174| 0|0|18.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendRequest`|netcoreapp3.1|193μs|264ns|1.02μs|0.193| 0|0|20.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendRequest`|net472|0.000558ns|0.000219ns|0.000819ns|0| 0|0|0 b| |#5714|`SendRequest`|net6.0|170μs|202ns|783ns|0.255| 0|0|18.44 KB| |#5714|`SendRequest`|netcoreapp3.1|191μs|342ns|1.33μs|0.193| 0|0|20.6 KB| |#5714|`SendRequest`|net472|2.69E‑05ns|2.69E‑05ns|0.000101ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net6.0|556μs|854ns|3.31μs|0.543| 0|0|41.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|657μs|650ns|2.34μs|0.324| 0|0|41.72 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net472|862μs|4.41μs|20.7μs|8.39| 2.52|0.419|53.23 KB| |#5714|`WriteAndFlushEnrichedTraces`|net6.0|559μs|430ns|1.67μs|0.551| 0|0|41.89 KB| |#5714|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|653μs|1.73μs|6.69μs|0.327| 0|0|41.86 KB| |#5714|`WriteAndFlushEnrichedTraces`|net472|863μs|4.25μs|18.5μs|8.33| 2.5|0.417|53.36 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteNonQuery`|net6.0|988ns|0.248ns|0.927ns|0.0114| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteNonQuery`|netcoreapp3.1|1.41μs|0.709ns|2.65ns|0.0106| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteNonQuery`|net472|1.78μs|3.02ns|11.7ns|0.122| 0|0|770 B| |#5714|`ExecuteNonQuery`|net6.0|1.08μs|0.483ns|1.87ns|0.0114| 0|0|808 B| |#5714|`ExecuteNonQuery`|netcoreapp3.1|1.53μs|0.882ns|3.3ns|0.0108| 0|0|808 B| |#5714|`ExecuteNonQuery`|net472|1.72μs|0.873ns|3.38ns|0.122| 0|0|770 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearch`|net6.0|1.19μs|1.05ns|4.06ns|0.0137| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearch`|netcoreapp3.1|1.54μs|1.34ns|5.2ns|0.0133| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearch`|net472|2.56μs|2.02ns|7.82ns|0.157| 0.00128|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearchAsync`|net6.0|1.28μs|0.414ns|1.6ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|0.467ns|1.81ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearchAsync`|net472|2.63μs|1.83ns|6.83ns|0.167| 0.00132|0|1.05 KB| |#5714|`CallElasticsearch`|net6.0|1.17μs|0.49ns|1.9ns|0.0136| 0|0|976 B| |#5714|`CallElasticsearch`|netcoreapp3.1|1.62μs|1.21ns|4.68ns|0.0129| 0|0|976 B| |#5714|`CallElasticsearch`|net472|2.48μs|1.34ns|5.03ns|0.157| 0|0|995 B| |#5714|`CallElasticsearchAsync`|net6.0|1.3μs|0.81ns|3.14ns|0.0137| 0|0|952 B| |#5714|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.629ns|2.27ns|0.0138| 0|0|1.02 KB| |#5714|`CallElasticsearchAsync`|net472|2.65μs|2.37ns|9.19ns|0.167| 0.00132|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5714 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.135 | 1,356.22 | 1,194.83 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteAsync`|net6.0|1.36μs|0.388ns|1.45ns|0.013| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteAsync`|netcoreapp3.1|1.55μs|0.805ns|2.9ns|0.0124| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteAsync`|net472|1.84μs|1.68ns|6.49ns|0.145| 0|0|915 B| |#5714|`ExecuteAsync`|net6.0|1.2μs|0.554ns|2.07ns|0.0131| 0|0|952 B| |#5714|`ExecuteAsync`|netcoreapp3.1|1.55μs|0.659ns|2.55ns|0.0124| 0|0|952 B| |#5714|`ExecuteAsync`|net472|1.85μs|0.719ns|2.69ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendAsync`|net6.0|4.35μs|1.45ns|5.43ns|0.0306| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendAsync`|netcoreapp3.1|5.05μs|1.42ns|5.49ns|0.0354| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendAsync`|net472|7.59μs|1.83ns|7.08ns|0.5| 0|0|3.15 KB| |#5714|`SendAsync`|net6.0|4.16μs|1.56ns|6.03ns|0.0311| 0|0|2.22 KB| |#5714|`SendAsync`|netcoreapp3.1|5.06μs|1.44ns|5.57ns|0.0356| 0|0|2.76 KB| |#5714|`SendAsync`|net472|7.57μs|1.81ns|6.78ns|0.498| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5714 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.134 | 1,465.32 | 1,661.81 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|1.47μs|0.529ns|1.98ns|0.0226| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|2.18μs|1.63ns|6.3ns|0.0222| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|2.57μs|1.55ns|6.02ns|0.249| 0|0|1.57 KB| |#5714|`EnrichedLog`|net6.0|1.66μs|0.993ns|3.85ns|0.0225| 0|0|1.64 KB| |#5714|`EnrichedLog`|netcoreapp3.1|2.24μs|1.45ns|5.42ns|0.0214| 0|0|1.64 KB| |#5714|`EnrichedLog`|net472|2.64μs|1.65ns|6.39ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|113μs|64.3ns|232ns|0.0566| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|117μs|95.7ns|358ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|146μs|51.1ns|184ns|0.657| 0.219|0|4.46 KB| |#5714|`EnrichedLog`|net6.0|115μs|116ns|449ns|0.057| 0|0|4.28 KB| |#5714|`EnrichedLog`|netcoreapp3.1|118μs|117ns|452ns|0| 0|0|4.28 KB| |#5714|`EnrichedLog`|net472|147μs|85.2ns|330ns|0.662| 0.221|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|3.2μs|1.01ns|3.65ns|0.0306| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|4.11μs|1.4ns|5.23ns|0.0287| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|4.88μs|2.21ns|8.54ns|0.32| 0|0|2.02 KB| |#5714|`EnrichedLog`|net6.0|2.94μs|1.65ns|6.19ns|0.0312| 0|0|2.2 KB| |#5714|`EnrichedLog`|netcoreapp3.1|4.21μs|1.97ns|7.36ns|0.0294| 0|0|2.2 KB| |#5714|`EnrichedLog`|net472|4.89μs|3.24ns|12.5ns|0.32| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendReceive`|net6.0|1.32μs|0.769ns|2.88ns|0.0158| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendReceive`|netcoreapp3.1|1.8μs|1.22ns|4.73ns|0.0154| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendReceive`|net472|1.97μs|0.883ns|3.42ns|0.183| 0.000983|0|1.16 KB| |#5714|`SendReceive`|net6.0|1.29μs|0.552ns|2.06ns|0.0161| 0|0|1.14 KB| |#5714|`SendReceive`|netcoreapp3.1|1.68μs|0.749ns|2.8ns|0.0152| 0|0|1.14 KB| |#5714|`SendReceive`|net472|2.05μs|0.554ns|2.07ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|2.69μs|0.887ns|3.32ns|0.0215| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|4.07μs|1.86ns|6.96ns|0.0224| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|4.45μs|2.99ns|11.2ns|0.324| 0|0|2.04 KB| |#5714|`EnrichedLog`|net6.0|2.69μs|1.05ns|4.08ns|0.0229| 0|0|1.6 KB| |#5714|`EnrichedLog`|netcoreapp3.1|3.94μs|1.74ns|6.72ns|0.0218| 0|0|1.65 KB| |#5714|`EnrichedLog`|net472|4.29μs|2.46ns|9.52ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5714 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.159 | 397.67 | 461.02 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishSpan`|net6.0|397ns|0.541ns|2.1ns|0.00816| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishSpan`|netcoreapp3.1|641ns|0.304ns|1.18ns|0.00771| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishSpan`|net472|646ns|0.364ns|1.36ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishScope`|net6.0|551ns|0.448ns|1.73ns|0.00968| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishScope`|netcoreapp3.1|755ns|0.695ns|2.41ns|0.00932| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishScope`|net472|797ns|0.682ns|2.64ns|0.105| 0|0|658 B| |#5714|`StartFinishSpan`|net6.0|461ns|0.222ns|0.861ns|0.0081| 0|0|576 B| |#5714|`StartFinishSpan`|netcoreapp3.1|616ns|2.5ns|9.68ns|0.00777| 0|0|576 B| |#5714|`StartFinishSpan`|net472|662ns|0.605ns|2.34ns|0.0916| 0|0|578 B| |#5714|`StartFinishScope`|net6.0|501ns|0.156ns|0.605ns|0.00971| 0|0|696 B| |#5714|`StartFinishScope`|netcoreapp3.1|700ns|0.524ns|1.81ns|0.00961| 0|0|696 B| |#5714|`StartFinishScope`|net472|825ns|0.498ns|1.93ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5714 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.126 | 689.56 | 612.34 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunOnMethodBegin`|net6.0|690ns|0.199ns|0.744ns|0.0097| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunOnMethodBegin`|netcoreapp3.1|946ns|0.382ns|1.48ns|0.00949| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunOnMethodBegin`|net472|1.09μs|0.668ns|2.59ns|0.104| 0|0|658 B| |#5714|`RunOnMethodBegin`|net6.0|612ns|0.122ns|0.472ns|0.00978| 0|0|696 B| |#5714|`RunOnMethodBegin`|netcoreapp3.1|911ns|1.31ns|5.08ns|0.00938| 0|0|696 B| |#5714|`RunOnMethodBegin`|net472|1.16μs|0.33ns|1.19ns|0.104| 0|0|658 B|
andrewlock commented 1 week ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5714) (11.660M)   : 0, 11660093
    master (11.593M)   : 0, 11593369
    benchmarks/2.9.0 (11.542M)   : 0, 11542126

    section Automatic
    This PR (5714) (7.810M)   : 0, 7809523
    master (7.827M)   : 0, 7827212
    benchmarks/2.9.0 (8.263M)   : 0, 8262905

    section Trace stats
    master (8.118M)   : 0, 8118390

    section Manual
    This PR (5714) (10.151M)   : 0, 10150667
    master (9.920M)   : 0, 9920204

    section Manual + Automatic
    This PR (5714) (7.419M)   : 0, 7418696
    master (7.358M)   : 0, 7357979

    section Version Conflict
    master (6.635M)   : 0, 6634804

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5714) (9.673M)   : 0, 9672650
    master (9.689M)   : 0, 9688586
    benchmarks/2.9.0 (9.596M)   : 0, 9596140

    section Automatic
    This PR (5714) (6.616M)   : 0, 6615957
    master (6.298M)   : 0, 6298066

    section Trace stats
    master (6.862M)   : 0, 6861645

    section Manual
    This PR (5714) (8.481M)   : 0, 8481153
    master (8.028M)   : 0, 8028063

    section Manual + Automatic
    This PR (5714) (6.143M)   : 0, 6142715
    master (6.139M)   : 0, 6139377

    section Version Conflict
    master (5.667M)   : 0, 5667497

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5714) (10.334M)   : 0, 10333593
    master (10.241M)   : 0, 10241408
    benchmarks/2.9.0 (10.213M)   : 0, 10213239

    section Automatic
    This PR (5714) (7.281M)   : 0, 7280835
    master (7.186M)   : 0, 7186302
    benchmarks/2.9.0 (7.482M)   : 0, 7482023

    section Trace stats
    master (7.568M)   : 0, 7568098

    section Manual
    This PR (5714) (9.154M)   : 0, 9154475
    master (9.213M)   : 0, 9213352

    section Manual + Automatic
    This PR (5714) (7.051M)   : 0, 7050998
    master (7.004M)   : 0, 7004280

    section Version Conflict
    master (6.289M)   : 0, 6288694