search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
413 stars 132 forks source link

Config refactor - Add telemetry to otel config #5717

Open andrewlock opened 1 week ago

andrewlock commented 1 week ago

Summary of changes

Records logs and metrics for when otel config is overriden by datadog config, or when it's invalid

Reason for change

This was originally part of https://github.com/DataDog/dd-trace-dotnet/pull/5661, but wasn't possible due to concerns with the fact ConfigurationBuilder is used in critical "startup" paths for the tracer, so can result in recursion if we're not careful.

Implementation details

The crux of the implementation is that we "store" error and metrics for writing at the point we know it's safe. This is similar to what we already do for configuration telemetry.

(Technically I think we Could directly access the TelemetryFactory.Metrics, but this is "safer", and makes it easier to test we're sending the right metrics

Test coverage

Added unit tests to all of the existing settings tests where we override configuration to confirm that it works as expected

Other details

The metrics etc are all ported from https://github.com/DataDog/dd-trace-dotnet/pull/5661, but there are currently some issues with the proposed values:

Part of a big ole stack:

datadog-ddstaging[bot] commented 1 week ago

Datadog Report

Branch report: andrew/config-refactor/5-record-otel-telemetry Commit report: 9302272 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 142 Passed, 0 Skipped, 1h 11m 27.35s Total Time

andrewlock commented 1 week ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (74ms)  : 62, 86
     .   : milestone, 74,
    master - mean (72ms)  : 63, 81
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (907ms)  : 887, 926
     .   : milestone, 907,
    master - mean (895ms)  : 874, 916
     .   : milestone, 895,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (109ms)  : 106, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (633ms)  : 612, 654
     .   : milestone, 633,
    master - mean (634ms)  : 618, 651
     .   : milestone, 634,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (594ms)  : 576, 612
     .   : milestone, 594,
    master - mean (591ms)  : 572, 610
     .   : milestone, 591,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (1,014ms)  : 980, 1047
     .   : milestone, 1014,
    master - mean (1,003ms)  : 974, 1031
     .   : milestone, 1003,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (275ms)  : 270, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (831ms)  : 805, 857
     .   : milestone, 831,
    master - mean (823ms)  : 791, 855
     .   : milestone, 823,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5717) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5717) - mean (809ms)  : 782, 837
     .   : milestone, 809,
    master - mean (811ms)  : 780, 843
     .   : milestone, 811,
andrewlock commented 1 week ago

Benchmarks Report for appsec :snail:

Benchmarks for #5717 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`AllCycleSimpleBody`|net6.0|71μs|93.8ns|351ns|0.0707| 0|0|6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`AllCycleSimpleBody`|netcoreapp3.1|61.4μs|75.9ns|294ns|0.0925| 0|0|6.94 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`AllCycleSimpleBody`|net472|47.2μs|81.6ns|316ns|1.32| 0|0|8.33 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`AllCycleMoreComplexBody`|net6.0|76.6μs|157ns|608ns|0.115| 0|0|9.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`AllCycleMoreComplexBody`|netcoreapp3.1|69.5μs|138ns|534ns|0.137| 0|0|10.36 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`AllCycleMoreComplexBody`|net472|54.6μs|118ns|456ns|1.87| 0.027|0|11.84 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ObjectExtractorSimpleBody`|net6.0|142ns|0.158ns|0.61ns|0.00395| 0|0|280 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ObjectExtractorSimpleBody`|netcoreapp3.1|200ns|0.153ns|0.572ns|0.00375| 0|0|272 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ObjectExtractorSimpleBody`|net472|179ns|0.216ns|0.838ns|0.0446| 0|0|281 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ObjectExtractorMoreComplexBody`|net6.0|3.1μs|1.78ns|6.67ns|0.0526| 0|0|3.78 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|4.05μs|1.54ns|5.75ns|0.0506| 0|0|3.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ObjectExtractorMoreComplexBody`|net472|3.8μs|2.98ns|11.6ns|0.602| 0.0057|0|3.8 KB| |#5717|`AllCycleSimpleBody`|net6.0|73.1μs|235ns|912ns|0.0728| 0|0|6 KB| |#5717|`AllCycleSimpleBody`|netcoreapp3.1|62.3μs|66.4ns|249ns|0.0933| 0|0|6.94 KB| |#5717|`AllCycleSimpleBody`|net472|46.8μs|62.1ns|240ns|1.32| 0|0|8.33 KB| |#5717|`AllCycleMoreComplexBody`|net6.0|77.9μs|71.2ns|266ns|0.116| 0|0|9.5 KB| |#5717|`AllCycleMoreComplexBody`|netcoreapp3.1|70.5μs|77.3ns|300ns|0.141| 0|0|10.36 KB| |#5717|`AllCycleMoreComplexBody`|net472|54.3μs|53.9ns|202ns|1.86| 0.0273|0|11.84 KB| |#5717|`ObjectExtractorSimpleBody`|net6.0|142ns|0.122ns|0.457ns|0.00398| 0|0|280 B| |#5717|`ObjectExtractorSimpleBody`|netcoreapp3.1|201ns|0.218ns|0.845ns|0.00371| 0|0|272 B| |#5717|`ObjectExtractorSimpleBody`|net472|170ns|0.127ns|0.492ns|0.0446| 0|0|281 B| |#5717|`ObjectExtractorMoreComplexBody`|net6.0|3.11μs|1.8ns|6.48ns|0.0527| 0|0|3.78 KB| |#5717|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|4.1μs|2.22ns|8.61ns|0.049| 0|0|3.69 KB| |#5717|`ObjectExtractorMoreComplexBody`|net472|3.91μs|2.9ns|10.5ns|0.602| 0.00583|0|3.8 KB|
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EncodeArgs`|net6.0|38.2μs|27.4ns|106ns|0.453| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EncodeArgs`|netcoreapp3.1|54.6μs|28.5ns|107ns|0.436| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EncodeArgs`|net472|66.4μs|53.8ns|201ns|5.14| 0.0663|0|32.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EncodeLegacyArgs`|net6.0|73.7μs|68.1ns|255ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EncodeLegacyArgs`|netcoreapp3.1|108μs|85.1ns|330ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EncodeLegacyArgs`|net472|157μs|47.5ns|178ns|0.311| 0|0|2.15 KB| |#5717|`EncodeArgs`|net6.0|37.7μs|40.1ns|150ns|0.454| 0|0|32.4 KB| |#5717|`EncodeArgs`|netcoreapp3.1|54.8μs|39.8ns|154ns|0.436| 0|0|32.4 KB| |#5717|`EncodeArgs`|net472|68.6μs|35.8ns|139ns|5.16| 0.0688|0|32.5 KB| |#5717|`EncodeLegacyArgs`|net6.0|77.7μs|420ns|2.3μs|0| 0|0|2.14 KB| |#5717|`EncodeLegacyArgs`|netcoreapp3.1|108μs|219ns|847ns|0| 0|0|2.14 KB| |#5717|`EncodeLegacyArgs`|net472|155μs|112ns|434ns|0.31| 0|0|2.15 KB|
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunWafRealisticBenchmark`|net6.0|181μs|55.2ns|206ns|0| 0|0|2.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunWafRealisticBenchmark`|netcoreapp3.1|196μs|351ns|1.36μs|0| 0|0|2.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunWafRealisticBenchmark`|net472|207μs|83.2ns|322ns|0.311| 0|0|2.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunWafRealisticBenchmarkWithAttack`|net6.0|121μs|98.5ns|382ns|0| 0|0|1.46 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|131μs|168ns|650ns|0| 0|0|1.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|50.2ns|195ns|0.208| 0|0|1.48 KB| |#5717|`RunWafRealisticBenchmark`|net6.0|180μs|56.3ns|211ns|0| 0|0|2.42 KB| |#5717|`RunWafRealisticBenchmark`|netcoreapp3.1|192μs|192ns|745ns|0| 0|0|2.37 KB| |#5717|`RunWafRealisticBenchmark`|net472|208μs|86.1ns|334ns|0.311| 0|0|2.43 KB| |#5717|`RunWafRealisticBenchmarkWithAttack`|net6.0|121μs|82.6ns|309ns|0| 0|0|1.46 KB| |#5717|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|128μs|177ns|686ns|0| 0|0|1.45 KB| |#5717|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|63.6ns|246ns|0.208| 0|0|1.48 KB|
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #5717 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 253.71 KB | 255.97 KB | 2.26 KB | 0.89% #### Fewer allocations :tada: in #5717 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 59.51 KB | 58.72 KB | -792 B | -1.33% | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 265.94 KB | 253.49 KB | -12.45 KB | -4.68% ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StringConcatBenchmark`|net6.0|59.4μs|599ns|5.93μs|0| 0|0|43.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StringConcatBenchmark`|netcoreapp3.1|54.4μs|275ns|1.23μs|0| 0|0|42.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StringConcatBenchmark`|net472|38.4μs|107ns|384ns|0| 0|0|59.51 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StringConcatAspectBenchmark`|net6.0|307μs|1.73μs|11.6μs|0| 0|0|265.94 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StringConcatAspectBenchmark`|netcoreapp3.1|312μs|4.51μs|43.7μs|0| 0|0|253.71 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StringConcatAspectBenchmark`|net472|280μs|4.34μs|42μs|0| 0|0|278.53 KB| |#5717|`StringConcatBenchmark`|net6.0|63.2μs|832ns|8.32μs|0| 0|0|43.44 KB| |#5717|`StringConcatBenchmark`|netcoreapp3.1|53.6μs|223ns|920ns|0| 0|0|42.64 KB| |#5717|`StringConcatBenchmark`|net472|38.2μs|135ns|488ns|0| 0|0|58.72 KB| |#5717|`StringConcatAspectBenchmark`|net6.0|292μs|5.06μs|48.3μs|0| 0|0|253.49 KB| |#5717|`StringConcatAspectBenchmark`|netcoreapp3.1|351μs|1.96μs|13μs|0| 0|0|255.97 KB| |#5717|`StringConcatAspectBenchmark`|net472|309μs|7.28μs|71.3μs|0| 0|0|278.53 KB|
andrewlock commented 1 week ago

Benchmarks Report for tracer :snail:

Benchmarks for #5717 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartStopWithChild`|net6.0|7.85μs|43.2ns|248ns|0.0193| 0.00773|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartStopWithChild`|netcoreapp3.1|10μs|55.4ns|354ns|0.0205| 0.0102|0|5.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartStopWithChild`|net472|16.7μs|62.2ns|241ns|1.02| 0.298|0.0994|6.06 KB| |#5717|`StartStopWithChild`|net6.0|7.62μs|40.9ns|213ns|0.0112| 0.00374|0|5.42 KB| |#5717|`StartStopWithChild`|netcoreapp3.1|9.92μs|55.9ns|375ns|0.0191| 0.00955|0|5.62 KB| |#5717|`StartStopWithChild`|net472|16.8μs|84.4ns|368ns|1.01| 0.291|0.0997|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net6.0|482μs|195ns|755ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|620μs|188ns|727ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net472|830μs|294ns|1.14μs|0.408| 0|0|3.3 KB| |#5717|`WriteAndFlushEnrichedTraces`|net6.0|494μs|1.01μs|3.77μs|0| 0|0|2.7 KB| |#5717|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|626μs|152ns|549ns|0| 0|0|2.7 KB| |#5717|`WriteAndFlushEnrichedTraces`|net472|816μs|223ns|862ns|0.406| 0|0|3.31 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendRequest`|net6.0|172μs|187ns|726ns|0.169| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendRequest`|netcoreapp3.1|190μs|275ns|1.03μs|0.191| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendRequest`|net472|0.00135ns|0.000409ns|0.00159ns|0| 0|0|0 b| |#5717|`SendRequest`|net6.0|172μs|237ns|917ns|0.258| 0|0|18.45 KB| |#5717|`SendRequest`|netcoreapp3.1|193μs|378ns|1.46μs|0.189| 0|0|20.61 KB| |#5717|`SendRequest`|net472|0.00144ns|0.000455ns|0.00176ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net6.0|549μs|529ns|2.05μs|0.553| 0|0|41.56 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|647μs|1.57μs|6.1μs|0.322| 0|0|41.79 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net472|856μs|4.14μs|18μs|8.19| 2.59|0.431|53.24 KB| |#5717|`WriteAndFlushEnrichedTraces`|net6.0|547μs|350ns|1.35μs|0.534| 0|0|41.58 KB| |#5717|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|651μs|1.25μs|4.85μs|0.327| 0|0|41.79 KB| |#5717|`WriteAndFlushEnrichedTraces`|net472|834μs|2.57μs|9.97μs|8.08| 2.55|0.425|53.22 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteNonQuery`|net6.0|1.2μs|0.606ns|2.27ns|0.0143| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteNonQuery`|netcoreapp3.1|1.66μs|1.01ns|3.89ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteNonQuery`|net472|1.92μs|0.803ns|2.9ns|0.156| 0|0|987 B| |#5717|`ExecuteNonQuery`|net6.0|1.31μs|1.17ns|4.52ns|0.0145| 0|0|1.02 KB| |#5717|`ExecuteNonQuery`|netcoreapp3.1|1.69μs|0.643ns|2.32ns|0.0134| 0|0|1.02 KB| |#5717|`ExecuteNonQuery`|net472|1.93μs|2.15ns|8.04ns|0.157| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearch`|net6.0|1.15μs|0.472ns|1.77ns|0.0138| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearch`|netcoreapp3.1|1.49μs|0.57ns|2.21ns|0.0133| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearch`|net472|2.52μs|2.43ns|9.4ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearchAsync`|net6.0|1.27μs|0.771ns|2.99ns|0.0134| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.757ns|2.83ns|0.0137| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearchAsync`|net472|2.59μs|1.34ns|5.21ns|0.166| 0|0|1.05 KB| |#5717|`CallElasticsearch`|net6.0|1.25μs|0.594ns|2.3ns|0.0138| 0|0|976 B| |#5717|`CallElasticsearch`|netcoreapp3.1|1.51μs|0.572ns|2.06ns|0.0134| 0|0|976 B| |#5717|`CallElasticsearch`|net472|2.55μs|3.01ns|11.7ns|0.157| 0|0|995 B| |#5717|`CallElasticsearchAsync`|net6.0|1.3μs|0.682ns|2.64ns|0.013| 0|0|952 B| |#5717|`CallElasticsearchAsync`|netcoreapp3.1|1.64μs|0.715ns|2.68ns|0.0141| 0|0|1.02 KB| |#5717|`CallElasticsearchAsync`|net472|2.64μs|1.99ns|7.7ns|0.166| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteAsync`|net6.0|1.31μs|3.73ns|14.5ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteAsync`|netcoreapp3.1|1.58μs|0.964ns|3.61ns|0.0127| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteAsync`|net472|1.83μs|0.751ns|2.91ns|0.145| 0|0|915 B| |#5717|`ExecuteAsync`|net6.0|1.27μs|1.14ns|4.25ns|0.0135| 0|0|952 B| |#5717|`ExecuteAsync`|netcoreapp3.1|1.69μs|1.49ns|5.58ns|0.0127| 0|0|952 B| |#5717|`ExecuteAsync`|net472|1.87μs|1.08ns|4.04ns|0.144| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendAsync`|net6.0|4.17μs|2.1ns|7.87ns|0.03| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendAsync`|netcoreapp3.1|5.07μs|4.24ns|16.4ns|0.0355| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendAsync`|net472|7.63μs|2.83ns|10.9ns|0.496| 0|0|3.15 KB| |#5717|`SendAsync`|net6.0|4.06μs|1.95ns|7.29ns|0.0325| 0|0|2.22 KB| |#5717|`SendAsync`|netcoreapp3.1|5.04μs|2.78ns|10.8ns|0.0353| 0|0|2.76 KB| |#5717|`SendAsync`|net472|7.66μs|2.33ns|8.72ns|0.498| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5717 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.125 | 1,434.02 | 1,612.82 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|1.43μs|1.03ns|4ns|0.0231| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|2.13μs|1.15ns|4.32ns|0.0217| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|2.43μs|0.87ns|3.26ns|0.25| 0|0|1.57 KB| |#5717|`EnrichedLog`|net6.0|1.61μs|0.701ns|2.53ns|0.0227| 0|0|1.64 KB| |#5717|`EnrichedLog`|netcoreapp3.1|2.18μs|0.665ns|2.4ns|0.0217| 0|0|1.64 KB| |#5717|`EnrichedLog`|net472|2.56μs|1.28ns|4.8ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|113μs|144ns|556ns|0.0569| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|120μs|204ns|792ns|0.0596| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|146μs|73.9ns|267ns|0.655| 0.218|0|4.46 KB| |#5717|`EnrichedLog`|net6.0|112μs|115ns|444ns|0.0559| 0|0|4.28 KB| |#5717|`EnrichedLog`|netcoreapp3.1|119μs|173ns|648ns|0.0587| 0|0|4.28 KB| |#5717|`EnrichedLog`|net472|145μs|60.5ns|227ns|0.652| 0.217|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|3.07μs|1ns|3.89ns|0.0311| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|4.09μs|1.17ns|4.39ns|0.0305| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|4.75μs|1.96ns|7.61ns|0.32| 0|0|2.02 KB| |#5717|`EnrichedLog`|net6.0|3.07μs|1.1ns|4.24ns|0.0308| 0|0|2.2 KB| |#5717|`EnrichedLog`|netcoreapp3.1|4.17μs|1.13ns|4.21ns|0.0286| 0|0|2.2 KB| |#5717|`EnrichedLog`|net472|5.16μs|2.81ns|10.9ns|0.319| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendReceive`|net6.0|1.32μs|0.358ns|1.34ns|0.0158| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendReceive`|netcoreapp3.1|1.67μs|4.75ns|18.4ns|0.015| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendReceive`|net472|2.14μs|1.36ns|5.27ns|0.183| 0.00107|0|1.16 KB| |#5717|`SendReceive`|net6.0|1.34μs|0.657ns|2.54ns|0.0162| 0|0|1.14 KB| |#5717|`SendReceive`|netcoreapp3.1|1.76μs|0.631ns|2.44ns|0.0151| 0|0|1.14 KB| |#5717|`SendReceive`|net472|2.02μs|0.912ns|3.53ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|2.64μs|0.668ns|2.5ns|0.0224| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|3.82μs|1.25ns|4.84ns|0.0211| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|4.35μs|3.34ns|12.9ns|0.323| 0|0|2.04 KB| |#5717|`EnrichedLog`|net6.0|2.7μs|0.525ns|2.03ns|0.0217| 0|0|1.6 KB| |#5717|`EnrichedLog`|netcoreapp3.1|3.87μs|1.93ns|7.48ns|0.0218| 0|0|1.65 KB| |#5717|`EnrichedLog`|net472|4.33μs|2.09ns|8.09ns|0.322| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishSpan`|net6.0|410ns|0.0999ns|0.387ns|0.00799| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishSpan`|netcoreapp3.1|613ns|0.188ns|0.728ns|0.00771| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishSpan`|net472|680ns|0.281ns|1.09ns|0.0915| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishScope`|net6.0|479ns|0.15ns|0.579ns|0.00989| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishScope`|netcoreapp3.1|761ns|0.409ns|1.58ns|0.00951| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishScope`|net472|830ns|0.418ns|1.62ns|0.104| 0|0|658 B| |#5717|`StartFinishSpan`|net6.0|402ns|0.109ns|0.424ns|0.00809| 0|0|576 B| |#5717|`StartFinishSpan`|netcoreapp3.1|619ns|0.144ns|0.56ns|0.00775| 0|0|576 B| |#5717|`StartFinishSpan`|net472|700ns|0.325ns|1.22ns|0.0918| 0|0|578 B| |#5717|`StartFinishScope`|net6.0|490ns|0.319ns|1.23ns|0.00985| 0|0|696 B| |#5717|`StartFinishScope`|netcoreapp3.1|705ns|0.254ns|0.986ns|0.00939| 0|0|696 B| |#5717|`StartFinishScope`|net472|829ns|0.318ns|1.23ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5717 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.146 | 582.94 | 668.34 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`RunOnMethodBegin`|net6.0|583ns|0.227ns|0.879ns|0.00963| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`RunOnMethodBegin`|netcoreapp3.1|927ns|0.212ns|0.765ns|0.00925| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`RunOnMethodBegin`|net472|1.05μs|0.544ns|2.11ns|0.104| 0|0|658 B| |#5717|`RunOnMethodBegin`|net6.0|668ns|0.185ns|0.668ns|0.0097| 0|0|696 B| |#5717|`RunOnMethodBegin`|netcoreapp3.1|960ns|0.932ns|3.61ns|0.00913| 0|0|696 B| |#5717|`RunOnMethodBegin`|net472|1.14μs|0.607ns|2.35ns|0.104| 0|0|658 B|
andrewlock commented 1 week ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5717) (11.820M)   : 0, 11819641
    master (11.941M)   : 0, 11940953
    benchmarks/2.9.0 (11.959M)   : 0, 11959218

    section Automatic
    This PR (5717) (7.984M)   : 0, 7983558
    master (8.126M)   : 0, 8125742
    benchmarks/2.9.0 (8.424M)   : 0, 8423539

    section Trace stats
    master (8.463M)   : 0, 8462913

    section Manual
    This PR (5717) (10.213M)   : 0, 10212632
    master (10.295M)   : 0, 10294729

    section Manual + Automatic
    This PR (5717) (7.517M)   : 0, 7517347
    master (7.548M)   : 0, 7547543

    section Version Conflict
    master (6.848M)   : 0, 6848367

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5717) (9.382M)   : 0, 9382173
    master (9.671M)   : 0, 9670503
    benchmarks/2.9.0 (9.647M)   : 0, 9646678

    section Automatic
    This PR (5717) (6.734M)   : 0, 6733673
    master (6.513M)   : 0, 6513280

    section Trace stats
    master (6.824M)   : 0, 6824339

    section Manual
    This PR (5717) (8.272M)   : 0, 8272072
    master (8.189M)   : 0, 8189017

    section Manual + Automatic
    This PR (5717) (6.213M)   : 0, 6213035
    master (6.236M)   : 0, 6235985

    section Version Conflict
    master (5.631M)   : 0, 5631298

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5717) (10.189M)   : 0, 10188971
    master (10.108M)   : 0, 10107819
    benchmarks/2.9.0 (10.154M)   : 0, 10153990

    section Automatic
    This PR (5717) (7.302M)   : 0, 7301745
    master (7.230M)   : 0, 7230329
    benchmarks/2.9.0 (7.563M)   : 0, 7562893

    section Trace stats
    master (7.514M)   : 0, 7513930

    section Manual
    This PR (5717) (9.161M)   : 0, 9161480
    master (8.979M)   : 0, 8979416

    section Manual + Automatic
    This PR (5717) (7.002M)   : 0, 7001539
    master (6.821M)   : 0, 6820517

    section Version Conflict
    master (6.181M)   : 0, 6181437