Closed link04 closed 1 day ago
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
master - mean (74ms) : 62, 85
. : milestone, 74,
section CallTarget+Inlining+NGEN
master - mean (945ms) : 815, 1075
. : milestone, 945,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
master - mean (120ms) : 111, 130
. : milestone, 120,
section CallTarget+Inlining+NGEN
master - mean (741ms) : 650, 832
. : milestone, 741,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
master - mean (122ms) : 119, 125
. : milestone, 122,
section CallTarget+Inlining+NGEN
master - mean (671ms) : 495, 848
. : milestone, 671,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
master - mean (191ms) : 187, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
master - mean (1,001ms) : 974, 1028
. : milestone, 1001,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
master - mean (276ms) : 273, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
master - mean (823ms) : 798, 849
. : milestone, 823,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
master - mean (265ms) : 262, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
master - mean (809ms) : 780, 839
. : milestone, 809,
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5721) (11.955M) : 0, 11955107
master (11.842M) : 0, 11842369
benchmarks/2.9.0 (12.049M) : 0, 12048905
section Automatic
This PR (5721) (7.897M) : 0, 7896532
master (7.999M) : 0, 7998666
benchmarks/2.9.0 (8.464M) : 0, 8463997
section Trace stats
master (8.337M) : 0, 8336641
section Manual
This PR (5721) (10.141M) : 0, 10140964
master (10.173M) : 0, 10173108
section Manual + Automatic
This PR (5721) (7.475M) : 0, 7474503
master (7.350M) : 0, 7349541
section Version Conflict
master (6.703M) : 0, 6702940
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5721) (9.591M) : 0, 9590887
master (9.512M) : 0, 9511621
benchmarks/2.9.0 (9.590M) : 0, 9590349
section Automatic
This PR (5721) (6.569M) : 0, 6569301
master (6.515M) : 0, 6515399
section Trace stats
master (6.862M) : 0, 6861752
section Manual
This PR (5721) (8.182M) : 0, 8181694
master (8.299M) : 0, 8298527
section Manual + Automatic
This PR (5721) (6.269M) : 0, 6269343
master (6.262M) : 0, 6262373
section Version Conflict
master (5.588M) : 0, 5588112
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5721) (10.263M) : 0, 10263454
master (10.162M) : 0, 10161696
benchmarks/2.9.0 (10.465M) : 0, 10465033
section Automatic
This PR (5721) (7.290M) : 0, 7290428
master (7.293M) : 0, 7293498
benchmarks/2.9.0 (7.635M) : 0, 7635248
section Trace stats
master (7.497M) : 0, 7496532
section Manual
This PR (5721) (8.976M) : 0, 8975771
master (9.243M) : 0, 9243291
section Manual + Automatic
This PR (5721) (7.050M) : 0, 7049924
master (6.976M) : 0, 6975655
section Version Conflict
master (6.267M) : 0, 6266553
Benchmarks for #5721 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Branch report: maximo/w3c-phase-3
Commit report: 459ca70
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 339424 Passed, 1624 Skipped, 14h 17m 29.29s Total Time
Summary of changes
Making sure that the Parent Id tag is set as expected based on the confirmation that the TraceIds match but the SpanIds don't when using the W3C headers, also setting the spanId based on that disconnected to keep try fixing the parent relation ship.
RFC: https://docs.google.com/document/d/1Zc7uAQTJ2G5vHEbmx8k4vMnYdQ-BnqZxewXk0ohgd3g/edit
Reason for change
To improve our interoperability with the
tracecontext
headers.Implementation details
Added the following to the SpanContextProgator.cs:
Test coverage
Added new test case based out of the system-tests cases for this feature: https://github.com/DataDog/system-tests/pull/2385