[Dynamic Instrumentation] DEBUG-2489 Add default 3rd party detection includes\excludes

dudikeleti commented 1 week ago

Summary of changes

Add the default 3rd party detection includes\excludes

datadog-ddstaging[bot] commented 1 week ago

Datadog Report

Branch report: dudik/3rdparty-includes-excludes Commit report: f81b6ef Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 44334 Passed, 106 Skipped, 25m 23.38s Total Time

andrewlock commented 1 week ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5722) - mean (74ms)  : 63, 85
     .   : milestone, 74,
    master - mean (74ms)  : 65, 84
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5722) - mean (913ms)  : 891, 935
     .   : milestone, 913,
    master - mean (911ms)  : 883, 939
     .   : milestone, 911,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5722) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5722) - mean (636ms)  : 619, 654
     .   : milestone, 636,
    master - mean (632ms)  : 618, 647
     .   : milestone, 632,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5722) - mean (95ms)  : 93, 97
     .   : milestone, 95,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5722) - mean (596ms)  : 576, 616
     .   : milestone, 596,
    master - mean (594ms)  : 574, 614
     .   : milestone, 594,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5722) - mean (192ms)  : 188, 197
     .   : milestone, 192,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5722) - mean (1,015ms)  : 986, 1045
     .   : milestone, 1015,
    master - mean (1,009ms)  : 979, 1040
     .   : milestone, 1009,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5722) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5722) - mean (818ms)  : 795, 842
     .   : milestone, 818,
    master - mean (824ms)  : 791, 856
     .   : milestone, 824,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5722) - mean (266ms)  : 261, 271
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5722) - mean (820ms)  : 790, 851
     .   : milestone, 820,
    master - mean (810ms)  : 782, 837
     .   : milestone, 810,

andrewlock commented 1 week ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5722) (11.540M)   : 0, 11539570
    master (11.716M)   : 0, 11716370
    benchmarks/2.9.0 (11.959M)   : 0, 11959218

    section Automatic
    This PR (5722) (7.721M)   : 0, 7721103
    master (8.019M)   : 0, 8019217
    benchmarks/2.9.0 (8.424M)   : 0, 8423539

    section Trace stats
    master (8.211M)   : 0, 8210949

    section Manual
    This PR (5722) (10.015M)   : 0, 10014833
    master (10.165M)   : 0, 10165125

    section Manual + Automatic
    This PR (5722) (7.408M)   : 0, 7407863
    master (7.491M)   : 0, 7491415

    section Version Conflict
    master (6.704M)   : 0, 6704048

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5722) (9.657M)   : 0, 9656850
    master (9.678M)   : 0, 9677607
    benchmarks/2.9.0 (9.647M)   : 0, 9646678

    section Automatic
    This PR (5722) (6.642M)   : 0, 6642457
    master (6.494M)   : 0, 6493916

    section Trace stats
    master (6.867M)   : 0, 6866744

    section Manual
    This PR (5722) (8.097M)   : 0, 8097218
    master (8.353M)   : 0, 8353119

    section Manual + Automatic
    This PR (5722) (6.106M)   : 0, 6105819
    master (6.149M)   : 0, 6148874

    section Version Conflict
    master (5.635M)   : 0, 5635422

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5722) (10.154M)   : 0, 10154316
    master (10.277M)   : 0, 10276790
    benchmarks/2.9.0 (10.154M)   : 0, 10153990

    section Automatic
    This PR (5722) (7.125M)   : 0, 7124662
    master (7.193M)   : 0, 7193100
    benchmarks/2.9.0 (7.563M)   : 0, 7562893

    section Trace stats
    master (7.542M)   : 0, 7542132

    section Manual
    This PR (5722) (8.943M)   : 0, 8943155
    master (9.045M)   : 0, 9045425

    section Manual + Automatic
    This PR (5722) (6.910M)   : 0, 6910064
    master (6.963M)   : 0, 6963205

    section Version Conflict
    master (6.250M)   : 0, 6250263

andrewlock commented 1 week ago

Benchmarks Report for tracer :snail:

Benchmarks for #5722 compared to master:

2 benchmarks are slower, with geometric mean 1.127
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartStopWithChild`|net6.0|7.85μs|43.2ns|248ns|0.0193| 0.00773|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartStopWithChild`|netcoreapp3.1|10μs|55.4ns|354ns|0.0205| 0.0102|0|5.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartStopWithChild`|net472|16.7μs|62.2ns|241ns|1.02| 0.298|0.0994|6.06 KB| |#5722|`StartStopWithChild`|net6.0|7.85μs|44.5ns|305ns|0.0158| 0.00789|0|5.42 KB| |#5722|`StartStopWithChild`|netcoreapp3.1|9.98μs|53.6ns|312ns|0.0139| 0.00464|0|5.62 KB| |#5722|`StartStopWithChild`|net472|17.1μs|54.4ns|211ns|1.03| 0.322|0.099|6.07 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net6.0|482μs|195ns|755ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|620μs|188ns|727ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net472|830μs|294ns|1.14μs|0.408| 0|0|3.3 KB| |#5722|`WriteAndFlushEnrichedTraces`|net6.0|480μs|603ns|2.33μs|0| 0|0|2.7 KB| |#5722|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|636μs|598ns|2.32μs|0| 0|0|2.7 KB| |#5722|`WriteAndFlushEnrichedTraces`|net472|812μs|249ns|931ns|0.406| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendRequest`|net6.0|172μs|187ns|726ns|0.169| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendRequest`|netcoreapp3.1|190μs|275ns|1.03μs|0.191| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendRequest`|net472|0.00135ns|0.000409ns|0.00159ns|0| 0|0|0 b| |#5722|`SendRequest`|net6.0|170μs|233ns|902ns|0.253| 0|0|18.45 KB| |#5722|`SendRequest`|netcoreapp3.1|193μs|258ns|997ns|0.193| 0|0|20.61 KB| |#5722|`SendRequest`|net472|0.00093ns|0.000322ns|0.00116ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #5722 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.56 KB | 41.78 KB | 226 B | 0.54%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net6.0|549μs|529ns|2.05μs|0.553| 0|0|41.56 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|647μs|1.57μs|6.1μs|0.322| 0|0|41.79 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`WriteAndFlushEnrichedTraces`|net472|856μs|4.14μs|18μs|8.19| 2.59|0.431|53.24 KB| |#5722|`WriteAndFlushEnrichedTraces`|net6.0|543μs|1.22μs|4.73μs|0.543| 0|0|41.78 KB| |#5722|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|641μs|764ns|2.86μs|0.322| 0|0|41.93 KB| |#5722|`WriteAndFlushEnrichedTraces`|net472|882μs|3.43μs|13.3μs|8.36| 2.64|0.44|53.24 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteNonQuery`|net6.0|1.2μs|0.606ns|2.27ns|0.0143| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteNonQuery`|netcoreapp3.1|1.66μs|1.01ns|3.89ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteNonQuery`|net472|1.92μs|0.803ns|2.9ns|0.156| 0|0|987 B| |#5722|`ExecuteNonQuery`|net6.0|1.33μs|0.263ns|0.948ns|0.014| 0|0|1.02 KB| |#5722|`ExecuteNonQuery`|netcoreapp3.1|1.58μs|0.705ns|2.64ns|0.0131| 0|0|1.02 KB| |#5722|`ExecuteNonQuery`|net472|1.97μs|4.11ns|15.9ns|0.156| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearch`|net6.0|1.15μs|0.472ns|1.77ns|0.0138| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearch`|netcoreapp3.1|1.49μs|0.57ns|2.21ns|0.0133| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearch`|net472|2.52μs|2.43ns|9.4ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearchAsync`|net6.0|1.27μs|0.771ns|2.99ns|0.0134| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.757ns|2.83ns|0.0137| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`CallElasticsearchAsync`|net472|2.59μs|1.34ns|5.21ns|0.166| 0|0|1.05 KB| |#5722|`CallElasticsearch`|net6.0|1.19μs|1.59ns|6.15ns|0.0137| 0|0|976 B| |#5722|`CallElasticsearch`|netcoreapp3.1|1.57μs|1.36ns|5.09ns|0.0127| 0|0|976 B| |#5722|`CallElasticsearch`|net472|2.56μs|1.54ns|5.98ns|0.158| 0|0|995 B| |#5722|`CallElasticsearchAsync`|net6.0|1.2μs|0.631ns|2.44ns|0.0133| 0|0|952 B| |#5722|`CallElasticsearchAsync`|netcoreapp3.1|1.71μs|0.817ns|3.16ns|0.0136| 0|0|1.02 KB| |#5722|`CallElasticsearchAsync`|net472|2.74μs|0.679ns|2.63ns|0.166| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteAsync`|net6.0|1.31μs|3.73ns|14.5ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteAsync`|netcoreapp3.1|1.58μs|0.964ns|3.61ns|0.0127| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`ExecuteAsync`|net472|1.83μs|0.751ns|2.91ns|0.145| 0|0|915 B| |#5722|`ExecuteAsync`|net6.0|1.28μs|0.454ns|1.7ns|0.0129| 0|0|952 B| |#5722|`ExecuteAsync`|netcoreapp3.1|1.64μs|0.83ns|3.22ns|0.0131| 0|0|952 B| |#5722|`ExecuteAsync`|net472|1.73μs|0.524ns|1.96ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendAsync`|net6.0|4.17μs|2.1ns|7.87ns|0.03| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendAsync`|netcoreapp3.1|5.07μs|4.24ns|16.4ns|0.0355| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendAsync`|net472|7.63μs|2.83ns|10.9ns|0.496| 0|0|3.15 KB| |#5722|`SendAsync`|net6.0|4.14μs|1.37ns|5.14ns|0.0311| 0|0|2.22 KB| |#5722|`SendAsync`|netcoreapp3.1|5.07μs|1.4ns|5.25ns|0.0357| 0|0|2.76 KB| |#5722|`SendAsync`|net472|7.58μs|6.69ns|25.9ns|0.498| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|1.43μs|1.03ns|4ns|0.0231| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|2.13μs|1.15ns|4.32ns|0.0217| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|2.43μs|0.87ns|3.26ns|0.25| 0|0|1.57 KB| |#5722|`EnrichedLog`|net6.0|1.43μs|0.679ns|2.54ns|0.0231| 0|0|1.64 KB| |#5722|`EnrichedLog`|netcoreapp3.1|2.12μs|0.771ns|2.78ns|0.0223| 0|0|1.64 KB| |#5722|`EnrichedLog`|net472|2.48μs|0.868ns|3.01ns|0.25| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|113μs|144ns|556ns|0.0569| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|120μs|204ns|792ns|0.0596| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|146μs|73.9ns|267ns|0.655| 0.218|0|4.46 KB| |#5722|`EnrichedLog`|net6.0|114μs|66.2ns|256ns|0.0571| 0|0|4.28 KB| |#5722|`EnrichedLog`|netcoreapp3.1|117μs|108ns|418ns|0.0585| 0|0|4.28 KB| |#5722|`EnrichedLog`|net472|149μs|51.1ns|198ns|0.664| 0.221|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|3.07μs|1ns|3.89ns|0.0311| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|4.09μs|1.17ns|4.39ns|0.0305| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|4.75μs|1.96ns|7.61ns|0.32| 0|0|2.02 KB| |#5722|`EnrichedLog`|net6.0|3.08μs|1.47ns|5.69ns|0.0305| 0|0|2.2 KB| |#5722|`EnrichedLog`|netcoreapp3.1|4.18μs|0.964ns|3.61ns|0.0293| 0|0|2.2 KB| |#5722|`EnrichedLog`|net472|4.97μs|2.08ns|8.05ns|0.319| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendReceive`|net6.0|1.32μs|0.358ns|1.34ns|0.0158| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendReceive`|netcoreapp3.1|1.67μs|4.75ns|18.4ns|0.015| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`SendReceive`|net472|2.14μs|1.36ns|5.27ns|0.183| 0.00107|0|1.16 KB| |#5722|`SendReceive`|net6.0|1.37μs|0.83ns|3.21ns|0.0165| 0|0|1.14 KB| |#5722|`SendReceive`|netcoreapp3.1|1.78μs|1.46ns|5.66ns|0.0151| 0|0|1.14 KB| |#5722|`SendReceive`|net472|2.09μs|1.57ns|6.07ns|0.184| 0|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net6.0|2.64μs|0.668ns|2.5ns|0.0224| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|netcoreapp3.1|3.82μs|1.25ns|4.84ns|0.0211| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`EnrichedLog`|net472|4.35μs|3.34ns|12.9ns|0.323| 0|0|2.04 KB| |#5722|`EnrichedLog`|net6.0|2.81μs|0.854ns|3.31ns|0.0225| 0|0|1.6 KB| |#5722|`EnrichedLog`|netcoreapp3.1|4.02μs|1.2ns|4.5ns|0.022| 0|0|1.65 KB| |#5722|`EnrichedLog`|net472|4.57μs|1.45ns|5.63ns|0.323| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5722 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.118 | 829.11 | 927.06 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishSpan`|net6.0|410ns|0.0999ns|0.387ns|0.00799| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishSpan`|netcoreapp3.1|613ns|0.188ns|0.728ns|0.00771| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishSpan`|net472|680ns|0.281ns|1.09ns|0.0915| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishScope`|net6.0|479ns|0.15ns|0.579ns|0.00989| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishScope`|netcoreapp3.1|761ns|0.409ns|1.58ns|0.00951| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`StartFinishScope`|net472|830ns|0.418ns|1.62ns|0.104| 0|0|658 B| |#5722|`StartFinishSpan`|net6.0|421ns|0.198ns|0.769ns|0.00819| 0|0|576 B| |#5722|`StartFinishSpan`|netcoreapp3.1|595ns|0.251ns|0.971ns|0.0078| 0|0|576 B| |#5722|`StartFinishSpan`|net472|632ns|0.571ns|2.21ns|0.0915| 0|0|578 B| |#5722|`StartFinishScope`|net6.0|473ns|0.188ns|0.726ns|0.00976| 0|0|696 B| |#5722|`StartFinishScope`|netcoreapp3.1|686ns|0.323ns|1.16ns|0.0093| 0|0|696 B| |#5722|`StartFinishScope`|net472|927ns|0.688ns|2.67ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5722 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.137 | 582.94 | 662.71 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`RunOnMethodBegin`|net6.0|583ns|0.227ns|0.879ns|0.00963| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`RunOnMethodBegin`|netcoreapp3.1|927ns|0.212ns|0.765ns|0.00925| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3d6d141c6c200710d7f1b6cd54968791b76f7953)|`RunOnMethodBegin`|net472|1.05μs|0.544ns|2.11ns|0.104| 0|0|658 B| |#5722|`RunOnMethodBegin`|net6.0|663ns|0.308ns|1.19ns|0.00999| 0|0|696 B| |#5722|`RunOnMethodBegin`|netcoreapp3.1|854ns|0.421ns|1.57ns|0.00938| 0|0|696 B| |#5722|`RunOnMethodBegin`|net472|1.12μs|0.33ns|1.14ns|0.105| 0|0|658 B|

DataDog / dd-trace-dotnet