Fix Gitlab build and codeCoverage bugs #5723

Closed andrewlock closed 3 months ago

Summary of changes

Fixes GitLab build broken in https://github.com/DataDog/dd-trace-dotnet/pull/5614
Fixes CodeCoverage calculations broken in https://github.com/DataDog/dd-trace-dotnet/pull/5718
Fixes profiler integration tests broken in https://github.com/DataDog/dd-trace-dotnet/pull/5718

Reason for change

The GitLab build was broken in #5614, due to a rogue dependency causing us to build the profiler native unit tests in GitLab
As part of the docker changes in #5718, accidentally enabled code coverage for all builds, which slows them down a lot.
Not all the stages were run in the previous build, so I broke some of them and didn't notice 🤦‍♂️

Implementation details

Remove the rogue dependency
Unify CodeCoverage and runCodeCoverage variables as CodeCoverageEnabled. It was getting (even more) confusing to reason about what was replacing what when running in docker compose, so unified to a single variable name across Nuke and pipelines. Now it's just very confusing instead of insanely confusing.
Add missing variables

Test coverage

Did a manual test in GitLab and all looks good. This is the test of the code coverage part.

Other details

Datadog Report

Branch report: andrew/ci/fix-gitlab-build Commit report: b0bedc5 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 11744 Passed, 10 Skipped, 43.72s Total Time

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5723) - mean (74ms)  : 65, 84
     .   : milestone, 74,
    master - mean (74ms)  : 65, 82
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5723) - mean (988ms)  : 969, 1007
     .   : milestone, 988,
    master - mean (987ms)  : 965, 1009
     .   : milestone, 987,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5723) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5723) - mean (690ms)  : 671, 709
     .   : milestone, 690,
    master - mean (693ms)  : 672, 715
     .   : milestone, 693,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5723) - mean (94ms)  : 91, 96
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5723) - mean (650ms)  : 630, 671
     .   : milestone, 650,
    master - mean (651ms)  : 628, 675
     .   : milestone, 651,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5723) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5723) - mean (1,078ms)  : 1056, 1100
     .   : milestone, 1078,
    master - mean (1,082ms)  : 1060, 1104
     .   : milestone, 1082,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5723) - mean (276ms)  : 271, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5723) - mean (863ms)  : 841, 885
     .   : milestone, 863,
    master - mean (865ms)  : 840, 890
     .   : milestone, 865,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5723) - mean (265ms)  : 260, 271
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5723) - mean (855ms)  : 834, 876
     .   : milestone, 855,
    master - mean (850ms)  : 830, 871
     .   : milestone, 850,

DataDog / dd-trace-dotnet