[Profiler] Add global flag to prevent the profiler from stackwalking while the app is crashing

gleocadie commented 3 months ago

Summary of changes

We prevent the profiler from collecting stacks (signal-based profilers) when the app is crashing.

Reason for change

We saw few callstacks reported by the CrashTracking product and it seems that the profiler crashes when collecting callstacks when the app is crashing. To avoid noise and mislead the investigation, we will set a flag that will tell the signal-based profilers to stop what they are doing.

Implementation details

Add a flag is_app_crashing in the wrapper to inform the profiler to not stackwalk.

Test coverage

Other details

datadog-ddstaging[bot] commented 3 months ago

Datadog Report

Branch report: gleocadie/prevent-profiler-from-from-sampling-thread-on-crash Commit report: 64015a7 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 335794 Passed, 1922 Skipped, 15h 43m 54.12s Total Time :snowflake: 1 New Flaky

New Flaky Tests (1)

NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyResolveMscorlibResourcesInfiniteRecursionCrashSmokeTest - Last Failure

Expand for error
``` Expected no errors in smoke test: ptrace(GETREGS, 15575) FAILED 3 (No such process) Expected: True Actual: False ```

andrewlock commented 3 months ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5729) - mean (72ms)  : 69, 75
     .   : milestone, 72,
    master - mean (73ms)  : 66, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5729) - mean (993ms)  : 966, 1021
     .   : milestone, 993,
    master - mean (987ms)  : 966, 1007
     .   : milestone, 987,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5729) - mean (110ms)  : 105, 116
     .   : milestone, 110,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5729) - mean (697ms)  : 676, 718
     .   : milestone, 697,
    master - mean (697ms)  : 677, 718
     .   : milestone, 697,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5729) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 89, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5729) - mean (654ms)  : 626, 682
     .   : milestone, 654,
    master - mean (652ms)  : 630, 675
     .   : milestone, 652,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5729) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5729) - mean (1,081ms)  : 1059, 1103
     .   : milestone, 1081,
    master - mean (1,080ms)  : 1055, 1104
     .   : milestone, 1080,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5729) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5729) - mean (872ms)  : 845, 899
     .   : milestone, 872,
    master - mean (869ms)  : 846, 892
     .   : milestone, 869,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5729) - mean (265ms)  : 262, 269
     .   : milestone, 265,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5729) - mean (855ms)  : 834, 876
     .   : milestone, 855,
    master - mean (851ms)  : 826, 875
     .   : milestone, 851,

andrewlock commented 3 months ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5729) (11.593M)   : 0, 11593400
    master (11.680M)   : 0, 11680352
    benchmarks/2.9.0 (11.545M)   : 0, 11545343

    section Automatic
    This PR (5729) (7.818M)   : 0, 7818112
    master (7.820M)   : 0, 7819638
    benchmarks/2.9.0 (8.126M)   : 0, 8125785

    section Trace stats
    master (8.158M)   : 0, 8157732

    section Manual
    This PR (5729) (9.996M)   : 0, 9996027
    master (9.925M)   : 0, 9924578

    section Manual + Automatic
    This PR (5729) (7.432M)   : 0, 7431905
    master (7.482M)   : 0, 7482449

    section Version Conflict
    master (6.635M)   : 0, 6634968

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5729) (9.473M)   : 0, 9472699
    master (9.294M)   : 0, 9294338
    benchmarks/2.9.0 (9.619M)   : 0, 9619209

    section Automatic
    This PR (5729) (6.523M)   : 0, 6522520
    master (6.468M)   : 0, 6468177

    section Trace stats
    master (6.754M)   : 0, 6754461

    section Manual
    This PR (5729) (8.218M)   : 0, 8218318
    master (8.162M)   : 0, 8161768

    section Manual + Automatic
    This PR (5729) (6.222M)   : 0, 6222419
    master (6.262M)   : 0, 6262414

    section Version Conflict
    master (5.565M)   : 0, 5565453

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5729) (10.061M)   : 0, 10061452
    master (10.199M)   : 0, 10198615
    benchmarks/2.9.0 (10.207M)   : 0, 10207218

    section Automatic
    This PR (5729) (7.072M)   : 0, 7071813
    master (7.255M)   : 0, 7255144
    benchmarks/2.9.0 (7.563M)   : 0, 7562593

    section Trace stats
    master (7.633M)   : 0, 7633330

    section Manual
    This PR (5729) (8.758M)   : 0, 8757722
    master (9.048M)   : 0, 9047753

    section Manual + Automatic
    This PR (5729) (6.721M)   : 0, 6720848
    master (6.964M)   : 0, 6963644

    section Version Conflict
    master (6.423M)   : 0, 6422917

andrewlock commented 3 months ago

Benchmarks Report for tracer :snail:

Benchmarks for #5729 compared to master:

1 benchmarks are faster, with geometric mean 1.125
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartStopWithChild`|net6.0|7.76μs|41.5ns|231ns|0.0194| 0.00777|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartStopWithChild`|netcoreapp3.1|10μs|47.9ns|192ns|0.0244| 0.00977|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartStopWithChild`|net472|16.1μs|51.5ns|199ns|1.02| 0.307|0.097|6.07 KB| |#5729|`StartStopWithChild`|net6.0|7.69μs|44ns|326ns|0.0153| 0.00383|0|5.42 KB| |#5729|`StartStopWithChild`|netcoreapp3.1|9.7μs|53.6ns|352ns|0.0144| 0.0048|0|5.62 KB| |#5729|`StartStopWithChild`|net472|16.2μs|47.8ns|179ns|1.02| 0.32|0.096|6.06 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`WriteAndFlushEnrichedTraces`|net6.0|489μs|98ns|353ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|621μs|114ns|411ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`WriteAndFlushEnrichedTraces`|net472|830μs|253ns|979ns|0.414| 0|0|3.3 KB| |#5729|`WriteAndFlushEnrichedTraces`|net6.0|476μs|274ns|1.06μs|0| 0|0|2.7 KB| |#5729|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|640μs|160ns|576ns|0| 0|0|2.7 KB| |#5729|`WriteAndFlushEnrichedTraces`|net472|831μs|351ns|1.36μs|0.417| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendRequest`|net6.0|170μs|158ns|613ns|0.17| 0|0|18.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendRequest`|netcoreapp3.1|190μs|326ns|1.26μs|0.19| 0|0|20.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendRequest`|net472|0ns|0ns|0ns|0| 0|0|0 b| |#5729|`SendRequest`|net6.0|171μs|255ns|987ns|0.171| 0|0|18.44 KB| |#5729|`SendRequest`|netcoreapp3.1|190μs|270ns|1.05μs|0.192| 0|0|20.6 KB| |#5729|`SendRequest`|net472|8.11E‑05ns|7.59E‑05ns|0.000284ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`WriteAndFlushEnrichedTraces`|net6.0|557μs|2.23μs|8.63μs|0.543| 0|0|41.79 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|651μs|1.33μs|5.17μs|0.326| 0|0|41.77 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`WriteAndFlushEnrichedTraces`|net472|852μs|4.29μs|20.1μs|8.39| 2.52|0.419|53.24 KB| |#5729|`WriteAndFlushEnrichedTraces`|net6.0|538μs|1.76μs|6.83μs|0.532| 0|0|41.81 KB| |#5729|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|664μs|739ns|2.76μs|0.327| 0|0|41.77 KB| |#5729|`WriteAndFlushEnrichedTraces`|net472|842μs|2.51μs|9.06μs|8.17| 2.45|0.408|53.22 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`ExecuteNonQuery`|net6.0|1.22μs|0.51ns|1.98ns|0.011| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`ExecuteNonQuery`|netcoreapp3.1|1.47μs|1.14ns|4.42ns|0.0111| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`ExecuteNonQuery`|net472|1.7μs|5.98ns|23.2ns|0.122| 0|0|770 B| |#5729|`ExecuteNonQuery`|net6.0|1.1μs|0.501ns|1.94ns|0.0115| 0|0|808 B| |#5729|`ExecuteNonQuery`|netcoreapp3.1|1.42μs|1.63ns|6.32ns|0.0112| 0|0|808 B| |#5729|`ExecuteNonQuery`|net472|1.73μs|0.538ns|2.01ns|0.122| 0|0|770 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`CallElasticsearch`|net6.0|1.28μs|3.82ns|14.8ns|0.014| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`CallElasticsearch`|netcoreapp3.1|1.54μs|2.36ns|9.12ns|0.0129| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`CallElasticsearch`|net472|2.53μs|2.17ns|7.83ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`CallElasticsearchAsync`|net6.0|1.35μs|1.47ns|5.69ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`CallElasticsearchAsync`|netcoreapp3.1|1.59μs|1.09ns|4.07ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`CallElasticsearchAsync`|net472|2.68μs|1.82ns|6.8ns|0.167| 0|0|1.05 KB| |#5729|`CallElasticsearch`|net6.0|1.15μs|0.443ns|1.66ns|0.0133| 0|0|976 B| |#5729|`CallElasticsearch`|netcoreapp3.1|1.52μs|0.498ns|1.8ns|0.013| 0|0|976 B| |#5729|`CallElasticsearch`|net472|2.41μs|0.702ns|2.53ns|0.157| 0.00122|0|995 B| |#5729|`CallElasticsearchAsync`|net6.0|1.32μs|0.767ns|2.97ns|0.0132| 0|0|952 B| |#5729|`CallElasticsearchAsync`|netcoreapp3.1|1.7μs|2.79ns|10.4ns|0.0135| 0|0|1.02 KB| |#5729|`CallElasticsearchAsync`|net472|2.62μs|1.31ns|4.55ns|0.167| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`ExecuteAsync`|net6.0|1.19μs|0.229ns|0.857ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`ExecuteAsync`|netcoreapp3.1|1.54μs|1.52ns|5.91ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`ExecuteAsync`|net472|1.72μs|0.912ns|3.41ns|0.145| 0|0|915 B| |#5729|`ExecuteAsync`|net6.0|1.28μs|0.453ns|1.69ns|0.0135| 0|0|952 B| |#5729|`ExecuteAsync`|netcoreapp3.1|1.64μs|1.15ns|4.16ns|0.0133| 0|0|952 B| |#5729|`ExecuteAsync`|net472|1.79μs|0.424ns|1.59ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendAsync`|net6.0|4.22μs|1.46ns|5.48ns|0.0296| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendAsync`|netcoreapp3.1|5.07μs|2.26ns|8.46ns|0.0357| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendAsync`|net472|7.73μs|2.49ns|9.66ns|0.499| 0|0|3.15 KB| |#5729|`SendAsync`|net6.0|4.25μs|1.02ns|3.83ns|0.0298| 0|0|2.22 KB| |#5729|`SendAsync`|netcoreapp3.1|5.14μs|1.67ns|6.47ns|0.0359| 0|0|2.76 KB| |#5729|`SendAsync`|net472|7.59μs|1.61ns|6.25ns|0.499| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net6.0|1.5μs|1.22ns|4.74ns|0.0231| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|netcoreapp3.1|2.2μs|1.35ns|5.24ns|0.022| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net472|2.54μs|1.52ns|5.71ns|0.249| 0|0|1.57 KB| |#5729|`EnrichedLog`|net6.0|1.43μs|0.419ns|1.62ns|0.0229| 0|0|1.64 KB| |#5729|`EnrichedLog`|netcoreapp3.1|2.24μs|0.953ns|3.69ns|0.0224| 0|0|1.64 KB| |#5729|`EnrichedLog`|net472|2.54μs|2.15ns|8.04ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net6.0|114μs|189ns|733ns|0.0564| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|netcoreapp3.1|117μs|99.8ns|386ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net472|147μs|135ns|525ns|0.658| 0.219|0|4.46 KB| |#5729|`EnrichedLog`|net6.0|112μs|59.3ns|222ns|0.0568| 0|0|4.28 KB| |#5729|`EnrichedLog`|netcoreapp3.1|120μs|202ns|782ns|0.0599| 0|0|4.28 KB| |#5729|`EnrichedLog`|net472|146μs|185ns|717ns|0.659| 0.22|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net6.0|3.03μs|1.16ns|4.34ns|0.0304| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|netcoreapp3.1|4.12μs|2.22ns|8.59ns|0.0293| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net472|4.85μs|1.56ns|6.03ns|0.321| 0|0|2.02 KB| |#5729|`EnrichedLog`|net6.0|3.04μs|0.633ns|2.28ns|0.0304| 0|0|2.2 KB| |#5729|`EnrichedLog`|netcoreapp3.1|4.21μs|5.04ns|19.5ns|0.0298| 0|0|2.2 KB| |#5729|`EnrichedLog`|net472|4.76μs|3.32ns|12.9ns|0.32| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendReceive`|net6.0|1.44μs|0.562ns|2.18ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendReceive`|netcoreapp3.1|1.8μs|1.49ns|5.78ns|0.0152| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`SendReceive`|net472|2.02μs|0.746ns|2.89ns|0.183| 0|0|1.16 KB| |#5729|`SendReceive`|net6.0|1.32μs|1.23ns|4.75ns|0.0159| 0|0|1.14 KB| |#5729|`SendReceive`|netcoreapp3.1|1.75μs|1.75ns|6.55ns|0.0157| 0|0|1.14 KB| |#5729|`SendReceive`|net472|2.1μs|2.67ns|10.3ns|0.184| 0|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net6.0|2.86μs|0.704ns|2.64ns|0.0214| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|netcoreapp3.1|3.89μs|1.57ns|6.09ns|0.0214| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`EnrichedLog`|net472|4.41μs|2.3ns|8.61ns|0.324| 0|0|2.04 KB| |#5729|`EnrichedLog`|net6.0|2.76μs|0.82ns|3.07ns|0.0221| 0|0|1.6 KB| |#5729|`EnrichedLog`|netcoreapp3.1|3.79μs|1.42ns|5.48ns|0.0209| 0|0|1.65 KB| |#5729|`EnrichedLog`|net472|4.53μs|5.95ns|23ns|0.322| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartFinishSpan`|net6.0|395ns|0.202ns|0.756ns|0.00809| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartFinishSpan`|netcoreapp3.1|564ns|0.237ns|0.916ns|0.00773| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartFinishSpan`|net472|633ns|0.249ns|0.93ns|0.0916| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartFinishScope`|net6.0|506ns|0.197ns|0.763ns|0.00962| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartFinishScope`|netcoreapp3.1|737ns|0.432ns|1.56ns|0.00959| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`StartFinishScope`|net472|859ns|0.579ns|2.24ns|0.104| 0|0|658 B| |#5729|`StartFinishSpan`|net6.0|404ns|1.11ns|4.31ns|0.00814| 0|0|576 B| |#5729|`StartFinishSpan`|netcoreapp3.1|577ns|0.294ns|1.14ns|0.00776| 0|0|576 B| |#5729|`StartFinishSpan`|net472|612ns|0.364ns|1.36ns|0.0916| 0|0|578 B| |#5729|`StartFinishScope`|net6.0|483ns|0.252ns|0.941ns|0.00969| 0|0|696 B| |#5729|`StartFinishScope`|netcoreapp3.1|707ns|0.268ns|1.04ns|0.00955| 0|0|696 B| |#5729|`StartFinishScope`|net472|800ns|0.439ns|1.7ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5729 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.125 | 751.24 | 668.00 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`RunOnMethodBegin`|net6.0|751ns|0.589ns|2.28ns|0.00983| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`RunOnMethodBegin`|netcoreapp3.1|869ns|0.529ns|2.05ns|0.00941| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/57ca38c27120aab981e4b25a20768374c9b74d9a)|`RunOnMethodBegin`|net472|1.14μs|0.687ns|2.66ns|0.104| 0|0|658 B| |#5729|`RunOnMethodBegin`|net6.0|668ns|0.222ns|0.861ns|0.00968| 0|0|696 B| |#5729|`RunOnMethodBegin`|netcoreapp3.1|919ns|0.439ns|1.64ns|0.00963| 0|0|696 B| |#5729|`RunOnMethodBegin`|net472|1.1μs|0.666ns|2.4ns|0.104| 0|0|658 B|

DataDog / dd-trace-dotnet