[v3] Annotate duck type proxies with type information

andrewlock commented 6 days ago

Summary of changes

Adds the ability to annotate duck types with type + assembly information
Annotates the types used with Datadog.Trace.Manual
Adds unit tests to make sure we don't break that duck typing contract
Fix minor bugs in instrumentation definitions

Reason for change

We need to be very careful we don't break duck types for our Datadog.Trace.Manual API when evolving Datadog.Trace. We have integration tests for this already, so this is just an extra layer of defense to make sure we don't change things without realizing the consequences.

Additionally, the proxy type annotations are required as part of the Native AOT work, so the attributes are based on work already started by @kevingosse in a branch: https://github.com/DataDog/dd-trace-dotnet/commit/a41cf637efd334c722b1c6e22f89b320609b3ebf

Implementation details

Add [DuckType] attribute, added to proxies to indicate the types they are designed to target
Add overload to [DuckCopy] for same purpose (I added this because it's what Kevin did, but maybe we should just stick to [DuckType], and have you add both?)
Add attributes to all proxies in Datadog.Trace that proxy something in Datadog.Trace.Manual
Add attributes to all types in Datadog.Trace.Manual that proxy something in Datadog.Trace!
- For example, the Datadog.Trace instrumentation creates a Datadog.Trace.Scope and then duck types that to a Datadog.Trace.Manual IScope
- Things get a bit messy when we're "reusing" types by linking into both projects, e.g. IScope. Made the interfaces partial to work around it for now, but we can probably simplify this down the line

Test coverage

Adds extra coverage

Other details

One oddity, is that I couldn't seem to DuckCast IScope to IScope 🤔 The duck typing complains about the missing (inherited) member void Dispose(). Ignored it for now, as in practice we're always (currently) duck typing a Scope which does work, but we may need to look into it again later

datadog-ddstaging[bot] commented 6 days ago

Datadog Report

Branch report: andrew/add-duck-type-checks Commit report: d00d4dc Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 424684 Passed, 3280 Skipped, 35h 9m 7.21s Total Time :hourglass: 4 Performance Regressions

:hourglass: Performance Regressions vs Default Branch (4)

ObjectExtractorMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark 4.5µs (+676ns, +18%) - Details
CallTarget+Inlining+NGEN - Samples.FakeDbCommand.windows.net462.json.scenarios 1.02s (+31.12ms, +3%) - Details
CallTarget+Inlining+NGEN - Samples.FakeDbCommand.windows.netcoreapp31.json.scenarios 720.31ms (+26.16ms, +4%) - Details
Baseline_garbagecollections - scenarios 1.08s (+75.72ms, +8%) - Details

andrewlock commented 6 days ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5742) - mean (74ms)  : 64, 84
     .   : milestone, 74,
    master - mean (74ms)  : 65, 83
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5742) - mean (1,020ms)  : 998, 1043
     .   : milestone, 1020,
    master - mean (991ms)  : 973, 1009
     .   : milestone, 991,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5742) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5742) - mean (720ms)  : 701, 740
     .   : milestone, 720,
    master - mean (698ms)  : 675, 722
     .   : milestone, 698,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5742) - mean (94ms)  : 90, 99
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5742) - mean (671ms)  : 637, 705
     .   : milestone, 671,
    master - mean (657ms)  : 630, 683
     .   : milestone, 657,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5742) - mean (193ms)  : 188, 198
     .   : milestone, 193,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5742) - mean (1,107ms)  : 1081, 1133
     .   : milestone, 1107,
    master - mean (1,081ms)  : 1059, 1103
     .   : milestone, 1081,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5742) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5742) - mean (896ms)  : 872, 921
     .   : milestone, 896,
    master - mean (874ms)  : 849, 899
     .   : milestone, 874,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5742) - mean (265ms)  : 261, 270
     .   : milestone, 265,
    master - mean (269ms)  : 263, 275
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (5742) - mean (876ms)  : 847, 904
     .   : milestone, 876,
    master - mean (867ms)  : 839, 894
     .   : milestone, 867,

andrewlock commented 6 days ago

Benchmarks Report for tracer :snail:

Benchmarks for #5742 compared to master:

1 benchmarks are faster, with geometric mean 1.116
1 benchmarks are slower, with geometric mean 1.150
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartStopWithChild`|net6.0|7.78μs|43.6ns|279ns|0.0154| 0.00768|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartStopWithChild`|netcoreapp3.1|9.78μs|52.8ns|280ns|0.0241| 0.00963|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartStopWithChild`|net472|16μs|49ns|190ns|1.01| 0.293|0.0952|6.07 KB| |#5742|`StartStopWithChild`|net6.0|7.68μs|42.9ns|297ns|0.0142| 0.00712|0|5.43 KB| |#5742|`StartStopWithChild`|netcoreapp3.1|9.91μs|49.8ns|239ns|0.0147| 0.00979|0|5.62 KB| |#5742|`StartStopWithChild`|net472|16.2μs|57.1ns|221ns|1.02| 0.301|0.0919|6.06 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`WriteAndFlushEnrichedTraces`|net6.0|489μs|145ns|563ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|640μs|294ns|1.14μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`WriteAndFlushEnrichedTraces`|net472|838μs|306ns|1.19μs|0.414| 0|0|3.3 KB| |#5742|`WriteAndFlushEnrichedTraces`|net6.0|480μs|273ns|1.02μs|0| 0|0|2.7 KB| |#5742|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|644μs|418ns|1.62μs|0| 0|0|2.7 KB| |#5742|`WriteAndFlushEnrichedTraces`|net472|818μs|240ns|897ns|0.406| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendRequest`|net6.0|170μs|229ns|886ns|0.168| 0|0|18.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendRequest`|netcoreapp3.1|191μs|299ns|1.16μs|0.192| 0|0|20.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendRequest`|net472|0.000295ns|0.000179ns|0.000692ns|0| 0|0|0 b| |#5742|`SendRequest`|net6.0|168μs|127ns|491ns|0.252| 0|0|18.44 KB| |#5742|`SendRequest`|netcoreapp3.1|191μs|242ns|937ns|0.19| 0|0|20.6 KB| |#5742|`SendRequest`|net472|3.51E‑05ns|3.51E‑05ns|0.000136ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`WriteAndFlushEnrichedTraces`|net6.0|547μs|312ns|1.12μs|0.543| 0|0|41.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|664μs|946ns|3.67μs|0.332| 0|0|41.89 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`WriteAndFlushEnrichedTraces`|net472|852μs|3.28μs|12.7μs|8.36| 2.64|0.44|53.25 KB| |#5742|`WriteAndFlushEnrichedTraces`|net6.0|564μs|555ns|2.15μs|0.558| 0|0|41.73 KB| |#5742|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|665μs|1.06μs|4.1μs|0.331| 0|0|41.68 KB| |#5742|`WriteAndFlushEnrichedTraces`|net472|852μs|4.37μs|20μs|8.39| 2.52|0.419|53.24 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ExecuteNonQuery`|net6.0|1μs|0.463ns|1.79ns|0.011| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ExecuteNonQuery`|netcoreapp3.1|1.48μs|0.933ns|3.61ns|0.011| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ExecuteNonQuery`|net472|1.74μs|0.748ns|2.9ns|0.122| 0|0|770 B| |#5742|`ExecuteNonQuery`|net6.0|1.09μs|0.513ns|1.99ns|0.0115| 0|0|808 B| |#5742|`ExecuteNonQuery`|netcoreapp3.1|1.49μs|0.763ns|2.96ns|0.0104| 0|0|808 B| |#5742|`ExecuteNonQuery`|net472|1.75μs|0.386ns|1.39ns|0.122| 0|0|770 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`CallElasticsearch`|net6.0|1.23μs|0.499ns|1.93ns|0.0141| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`CallElasticsearch`|netcoreapp3.1|1.48μs|0.716ns|2.58ns|0.0134| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`CallElasticsearch`|net472|2.43μs|1.49ns|5.77ns|0.157| 0.00121|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`CallElasticsearchAsync`|net6.0|1.23μs|1.16ns|4.34ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|0.763ns|2.85ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`CallElasticsearchAsync`|net472|2.65μs|1.89ns|7.33ns|0.167| 0.00132|0|1.05 KB| |#5742|`CallElasticsearch`|net6.0|1.17μs|0.514ns|1.92ns|0.014| 0|0|976 B| |#5742|`CallElasticsearch`|netcoreapp3.1|1.5μs|1.54ns|5.78ns|0.0133| 0|0|976 B| |#5742|`CallElasticsearch`|net472|2.44μs|1.64ns|6.36ns|0.158| 0.00122|0|995 B| |#5742|`CallElasticsearchAsync`|net6.0|1.22μs|0.722ns|2.8ns|0.0136| 0|0|952 B| |#5742|`CallElasticsearchAsync`|netcoreapp3.1|1.79μs|1.3ns|5.05ns|0.0133| 0|0|1.02 KB| |#5742|`CallElasticsearchAsync`|net472|2.64μs|1.47ns|5.68ns|0.167| 0.00132|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ExecuteAsync`|net6.0|1.22μs|0.474ns|1.84ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ExecuteAsync`|netcoreapp3.1|1.68μs|2.5ns|9.69ns|0.0126| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ExecuteAsync`|net472|1.78μs|1.12ns|4.32ns|0.145| 0|0|915 B| |#5742|`ExecuteAsync`|net6.0|1.19μs|0.589ns|2.2ns|0.0132| 0|0|952 B| |#5742|`ExecuteAsync`|netcoreapp3.1|1.65μs|3.04ns|11.4ns|0.0124| 0|0|952 B| |#5742|`ExecuteAsync`|net472|1.76μs|0.706ns|2.64ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendAsync`|net6.0|4.22μs|2.32ns|8.99ns|0.0295| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendAsync`|netcoreapp3.1|5.12μs|2.73ns|10.2ns|0.0382| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendAsync`|net472|7.52μs|1.46ns|5.45ns|0.499| 0|0|3.15 KB| |#5742|`SendAsync`|net6.0|4.2μs|1.34ns|4.63ns|0.0296| 0|0|2.22 KB| |#5742|`SendAsync`|netcoreapp3.1|5.03μs|1.61ns|6.04ns|0.0379| 0|0|2.76 KB| |#5742|`SendAsync`|net472|7.66μs|1.52ns|5.46ns|0.497| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5742 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 | 1.116 | 2,619.59 | 2,347.84 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net6.0|1.61μs|0.474ns|1.71ns|0.0226| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|netcoreapp3.1|2.1μs|0.702ns|2.63ns|0.0221| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net472|2.62μs|1.87ns|7.01ns|0.25| 0|0|1.57 KB| |#5742|`EnrichedLog`|net6.0|1.5μs|0.748ns|2.8ns|0.0226| 0|0|1.64 KB| |#5742|`EnrichedLog`|netcoreapp3.1|2.14μs|1.86ns|6.96ns|0.0216| 0|0|1.64 KB| |#5742|`EnrichedLog`|net472|2.35μs|0.925ns|3.46ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net6.0|114μs|261ns|1.01μs|0.057| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|netcoreapp3.1|119μs|188ns|726ns|0.0605| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net472|147μs|97.3ns|377ns|0.658| 0.219|0|4.46 KB| |#5742|`EnrichedLog`|net6.0|114μs|164ns|634ns|0.056| 0|0|4.28 KB| |#5742|`EnrichedLog`|netcoreapp3.1|118μs|233ns|904ns|0| 0|0|4.28 KB| |#5742|`EnrichedLog`|net472|147μs|62.5ns|242ns|0.664| 0.221|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net6.0|2.93μs|0.882ns|3.42ns|0.0304| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|netcoreapp3.1|4.1μs|1.35ns|4.86ns|0.0288| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net472|4.87μs|5.57ns|19.3ns|0.32| 0|0|2.02 KB| |#5742|`EnrichedLog`|net6.0|3.03μs|0.791ns|3.06ns|0.0304| 0|0|2.2 KB| |#5742|`EnrichedLog`|netcoreapp3.1|4.27μs|2.27ns|8.78ns|0.03| 0|0|2.2 KB| |#5742|`EnrichedLog`|net472|4.92μs|0.946ns|3.66ns|0.321| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendReceive`|net6.0|1.32μs|0.73ns|2.73ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendReceive`|netcoreapp3.1|1.74μs|1.63ns|6.32ns|0.0149| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`SendReceive`|net472|1.98μs|1.51ns|5.67ns|0.183| 0.000988|0|1.16 KB| |#5742|`SendReceive`|net6.0|1.32μs|0.819ns|3.17ns|0.0158| 0|0|1.14 KB| |#5742|`SendReceive`|netcoreapp3.1|1.7μs|0.816ns|3.16ns|0.015| 0|0|1.14 KB| |#5742|`SendReceive`|net472|2.06μs|1.77ns|6.39ns|0.183| 0.00102|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net6.0|2.76μs|0.51ns|1.91ns|0.022| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|netcoreapp3.1|3.83μs|2.96ns|11.1ns|0.0226| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EnrichedLog`|net472|4.34μs|1.34ns|5.02ns|0.323| 0|0|2.04 KB| |#5742|`EnrichedLog`|net6.0|2.68μs|0.881ns|3.3ns|0.0216| 0|0|1.6 KB| |#5742|`EnrichedLog`|netcoreapp3.1|4.12μs|1.73ns|6.47ns|0.0225| 0|0|1.65 KB| |#5742|`EnrichedLog`|net472|4.41μs|1.03ns|3.85ns|0.322| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5742 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.150 | 403.30 | 463.90 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartFinishSpan`|net6.0|403ns|0.338ns|1.31ns|0.0081| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartFinishSpan`|netcoreapp3.1|602ns|0.431ns|1.55ns|0.00789| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartFinishSpan`|net472|686ns|0.62ns|2.4ns|0.0915| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartFinishScope`|net6.0|551ns|0.815ns|3.16ns|0.00967| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartFinishScope`|netcoreapp3.1|703ns|0.375ns|1.45ns|0.00948| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StartFinishScope`|net472|869ns|0.795ns|3.08ns|0.105| 0|0|658 B| |#5742|`StartFinishSpan`|net6.0|464ns|0.166ns|0.642ns|0.00817| 0|0|576 B| |#5742|`StartFinishSpan`|netcoreapp3.1|622ns|0.171ns|0.617ns|0.00775| 0|0|576 B| |#5742|`StartFinishSpan`|net472|658ns|0.694ns|2.69ns|0.0918| 0|0|578 B| |#5742|`StartFinishScope`|net6.0|501ns|0.177ns|0.686ns|0.0098| 0|0|696 B| |#5742|`StartFinishScope`|netcoreapp3.1|696ns|0.35ns|1.36ns|0.00933| 0|0|696 B| |#5742|`StartFinishScope`|net472|876ns|0.711ns|2.75ns|0.105| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunOnMethodBegin`|net6.0|607ns|0.164ns|0.636ns|0.00971| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunOnMethodBegin`|netcoreapp3.1|882ns|0.563ns|2.1ns|0.0093| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunOnMethodBegin`|net472|1.04μs|0.653ns|2.53ns|0.104| 0|0|658 B| |#5742|`RunOnMethodBegin`|net6.0|601ns|0.212ns|0.82ns|0.00968| 0|0|696 B| |#5742|`RunOnMethodBegin`|netcoreapp3.1|906ns|0.848ns|3.28ns|0.00964| 0|0|696 B| |#5742|`RunOnMethodBegin`|net472|1.07μs|1.33ns|5.15ns|0.104| 0|0|658 B|

andrewlock commented 6 days ago

Benchmarks Report for appsec :snail:

Benchmarks for #5742 compared to master:

1 benchmarks are slower, with geometric mean 1.174
1 benchmarks have fewer allocations
2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5742 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 | 1.174 | 3,831.86 | 4,496.94 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`AllCycleSimpleBody`|net6.0|70.7μs|47.8ns|179ns|0.0703| 0|0|6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`AllCycleSimpleBody`|netcoreapp3.1|61.5μs|98.5ns|381ns|0.0917| 0|0|6.94 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`AllCycleSimpleBody`|net472|47.8μs|32.1ns|116ns|1.31| 0|0|8.33 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`AllCycleMoreComplexBody`|net6.0|77.5μs|74ns|267ns|0.116| 0|0|9.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`AllCycleMoreComplexBody`|netcoreapp3.1|69μs|78.1ns|303ns|0.138| 0|0|10.36 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`AllCycleMoreComplexBody`|net472|54.6μs|58.5ns|227ns|1.88| 0.0272|0|11.84 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ObjectExtractorSimpleBody`|net6.0|142ns|0.101ns|0.392ns|0.00393| 0|0|280 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ObjectExtractorSimpleBody`|netcoreapp3.1|209ns|0.441ns|1.71ns|0.00377| 0|0|272 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ObjectExtractorSimpleBody`|net472|171ns|0.117ns|0.452ns|0.0446| 0|0|281 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ObjectExtractorMoreComplexBody`|net6.0|3.08μs|3.07ns|11.5ns|0.0537| 0|0|3.78 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|4.16μs|2.75ns|10.3ns|0.0503| 0|0|3.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`ObjectExtractorMoreComplexBody`|net472|3.84μs|3.67ns|14.2ns|0.603| 0.00578|0|3.8 KB| |#5742|`AllCycleSimpleBody`|net6.0|72.7μs|103ns|398ns|0.0722| 0|0|6 KB| |#5742|`AllCycleSimpleBody`|netcoreapp3.1|61.9μs|94.5ns|366ns|0.0927| 0|0|6.94 KB| |#5742|`AllCycleSimpleBody`|net472|47.2μs|38.6ns|144ns|1.32| 0|0|8.33 KB| |#5742|`AllCycleMoreComplexBody`|net6.0|77.8μs|70.2ns|263ns|0.117| 0|0|9.5 KB| |#5742|`AllCycleMoreComplexBody`|netcoreapp3.1|68.6μs|113ns|436ns|0.137| 0|0|10.36 KB| |#5742|`AllCycleMoreComplexBody`|net472|53.6μs|39.9ns|154ns|1.87| 0.0267|0|11.84 KB| |#5742|`ObjectExtractorSimpleBody`|net6.0|151ns|0.207ns|0.802ns|0.00392| 0|0|280 B| |#5742|`ObjectExtractorSimpleBody`|netcoreapp3.1|228ns|0.193ns|0.747ns|0.00367| 0|0|272 B| |#5742|`ObjectExtractorSimpleBody`|net472|168ns|0.167ns|0.647ns|0.0446| 0|0|281 B| |#5742|`ObjectExtractorMoreComplexBody`|net6.0|3.12μs|1.28ns|4.6ns|0.0531| 0|0|3.78 KB| |#5742|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|4.06μs|2.11ns|8.18ns|0.0489| 0|0|3.69 KB| |#5742|`ObjectExtractorMoreComplexBody`|net472|4.5μs|1.9ns|7.1ns|0.601| 0.00676|0|3.8 KB|

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EncodeArgs`|net6.0|38μs|14.2ns|53ns|0.452| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EncodeArgs`|netcoreapp3.1|54.2μs|18ns|67.5ns|0.433| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EncodeArgs`|net472|68μs|52.7ns|204ns|5.15| 0.0673|0|32.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EncodeLegacyArgs`|net6.0|77.1μs|371ns|1.48μs|0.0386| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EncodeLegacyArgs`|netcoreapp3.1|105μs|113ns|422ns|0| 0|0|2.15 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`EncodeLegacyArgs`|net472|156μs|50.6ns|196ns|0.311| 0|0|2.15 KB| |#5742|`EncodeArgs`|net6.0|37.9μs|20.7ns|80.1ns|0.455| 0|0|32.4 KB| |#5742|`EncodeArgs`|netcoreapp3.1|53.9μs|25.9ns|100ns|0.429| 0|0|32.4 KB| |#5742|`EncodeArgs`|net472|67.3μs|35.5ns|138ns|5.16| 0.067|0|32.5 KB| |#5742|`EncodeLegacyArgs`|net6.0|75.5μs|25.1ns|90.4ns|0| 0|0|2.14 KB| |#5742|`EncodeLegacyArgs`|netcoreapp3.1|108μs|43.3ns|168ns|0| 0|0|2.14 KB| |#5742|`EncodeLegacyArgs`|net472|159μs|58.8ns|220ns|0.316| 0|0|2.15 KB|

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunWafRealisticBenchmark`|net6.0|181μs|57.4ns|215ns|0| 0|0|2.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunWafRealisticBenchmark`|netcoreapp3.1|193μs|84.5ns|327ns|0| 0|0|2.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunWafRealisticBenchmark`|net472|207μs|36.9ns|138ns|0.309| 0|0|2.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunWafRealisticBenchmarkWithAttack`|net6.0|122μs|135ns|524ns|0| 0|0|1.46 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|129μs|142ns|549ns|0| 0|0|1.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|33.6ns|126ns|0.209| 0|0|1.48 KB| |#5742|`RunWafRealisticBenchmark`|net6.0|180μs|53.3ns|199ns|0| 0|0|2.42 KB| |#5742|`RunWafRealisticBenchmark`|netcoreapp3.1|192μs|118ns|456ns|0| 0|0|2.37 KB| |#5742|`RunWafRealisticBenchmark`|net472|207μs|138ns|535ns|0.311| 0|0|2.43 KB| |#5742|`RunWafRealisticBenchmarkWithAttack`|net6.0|122μs|44.6ns|167ns|0| 0|0|1.46 KB| |#5742|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|130μs|108ns|419ns|0| 0|0|1.45 KB| |#5742|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|43.8ns|170ns|0.207| 0|0|1.48 KB|

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #5742 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 254.22 KB | 256.58 KB | 2.36 KB | 0.93% | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 253.9 KB | 255.66 KB | 1.75 KB | 0.69% #### Fewer allocations :tada: in #5742 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 62.16 KB | 57.9 KB | -4.26 KB | -6.86%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StringConcatBenchmark`|net6.0|58.2μs|739ns|7.13μs|0| 0|0|43.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StringConcatBenchmark`|netcoreapp3.1|53.5μs|258ns|999ns|0| 0|0|42.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StringConcatBenchmark`|net472|37.5μs|104ns|389ns|0| 0|0|62.16 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StringConcatAspectBenchmark`|net6.0|298μs|6.69μs|66.2μs|0| 0|0|254.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StringConcatAspectBenchmark`|netcoreapp3.1|334μs|1.9μs|13.9μs|0| 0|0|253.9 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/0f17e5756636c7ced13cdd7d003fe6dbca1039dc)|`StringConcatAspectBenchmark`|net472|284μs|4μs|38.3μs|0| 0|0|278.53 KB| |#5742|`StringConcatBenchmark`|net6.0|61μs|818ns|8.05μs|0| 0|0|43.44 KB| |#5742|`StringConcatBenchmark`|netcoreapp3.1|54.3μs|265ns|1.12μs|0| 0|0|42.64 KB| |#5742|`StringConcatBenchmark`|net472|38.2μs|62.1ns|215ns|0| 0|0|57.9 KB| |#5742|`StringConcatAspectBenchmark`|net6.0|307μs|1.65μs|9.21μs|0| 0|0|256.58 KB| |#5742|`StringConcatAspectBenchmark`|netcoreapp3.1|340μs|2.64μs|25.9μs|0| 0|0|255.66 KB| |#5742|`StringConcatAspectBenchmark`|net472|290μs|5.39μs|52.2μs|0| 0|0|278.53 KB|

andrewlock commented 6 days ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5742) (11.771M)   : 0, 11771083
    master (11.753M)   : 0, 11753412
    benchmarks/2.9.0 (11.542M)   : 0, 11542126

    section Automatic
    This PR (5742) (8.123M)   : 0, 8123367
    master (7.853M)   : 0, 7853279
    benchmarks/2.9.0 (8.263M)   : 0, 8262905

    section Trace stats
    master (8.259M)   : 0, 8258966

    section Manual
    master (9.899M)   : 0, 9899401

    section Manual + Automatic
    This PR (5742) (7.441M)   : 0, 7440994
    master (7.433M)   : 0, 7432897

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5742) (9.447M)   : 0, 9446866
    master (9.574M)   : 0, 9574121
    benchmarks/2.9.0 (9.596M)   : 0, 9596140

    section Automatic
    This PR (5742) (6.712M)   : 0, 6712063
    master (6.671M)   : 0, 6671192

    section Trace stats
    master (6.990M)   : 0, 6990244

    section Manual
    master (8.307M)   : 0, 8306500

    section Manual + Automatic
    This PR (5742) (6.241M)   : 0, 6240534
    master (6.251M)   : 0, 6250704

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5742) (9.911M)   : 0, 9911223
    master (10.202M)   : 0, 10201759
    benchmarks/2.9.0 (10.213M)   : 0, 10213239

    section Automatic
    This PR (5742) (6.924M)   : 0, 6923985
    master (7.212M)   : 0, 7212394
    benchmarks/2.9.0 (7.482M)   : 0, 7482023

    section Trace stats
    master (7.549M)   : 0, 7549360

    section Manual
    master (9.013M)   : 0, 9012822

    section Manual + Automatic
    This PR (5742) (6.551M)   : crit ,0, 6551045
    master (7.018M)   : 0, 7017920

DataDog / dd-trace-dotnet